Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize checks for <a>, <area>, <form>, and <link> #2613

Merged
merged 5 commits into from Sep 22, 2017

Conversation

@annevk
Copy link
Member

commented May 2, 2017

@annevk annevk force-pushed the annevk/simplify-a-area-link branch from 6f5078f to 3becdd1 May 2, 2017
annevk added a commit to web-platform-tests/wpt that referenced this pull request May 2, 2017
Follow-up test for whatwg/html#2613.
@annevk

This comment has been minimized.

Copy link
Member Author

commented May 2, 2017

Sigh. This is wrong, because we'd also have to add the check to "download the hyperlink". The whole setup seems rather broken though.

@annevk

This comment has been minimized.

Copy link
Member Author

commented May 2, 2017

And with broken I mean that "download the hyperlink" shouldn't have to do its own URL processing and such.

@annevk annevk force-pushed the annevk/simplify-a-area-link branch from 3becdd1 to 5cd556f May 3, 2017
@annevk annevk changed the title Centralize active document checks for <a>, <area>, and <link> Centralize checks for <a>, <area>, <form>, and <link> May 3, 2017
@annevk

This comment has been minimized.

Copy link
Member Author

commented May 3, 2017

I updated the commit to address #2615 per how I think it should be addressed and also addressed my own review feedback above. I will also update the three test PRs to align with the proposed change.

@annevk annevk force-pushed the annevk/simplify-a-area-link branch from 5cd556f to 475c12a May 9, 2017
Copy link
Member

left a comment

LGTM with nit, but we'll mark "do not merge yet" pending compat analysis in #2615.

source Outdated
</ol>
<!-- c.f. <link> and <a>'s similar section -->
<p>The <span>activation behavior</span> of <code>area</code> elements is to <span
data-x="following hyperlinks">Follow the hyperlink</span> or <span data-x="downloading

This comment has been minimized.

Copy link
@domenic

domenic May 10, 2017

Member

Nit: lowercase "follow"

Require that they are all connected to a document that is fully
active. There is enough difference between implementations that this
appears to be web compatible.

Tests:

* web-platform-tests/wpt#5758
* web-platform-tests/wpt#5759
* web-platform-tests/wpt#5761

Fixes #2615.
@annevk annevk force-pushed the annevk/simplify-a-area-link branch from 475c12a to dd32b3d Aug 23, 2017
annevk added 3 commits Aug 23, 2017
nit
fixes #2708
annevk added a commit to web-platform-tests/wpt that referenced this pull request Aug 23, 2017
@annevk

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2017

Updated PR and tests per findings in #2615 and #2708 (has a list of browser bugs that need updating upon this landing).

source Outdated
<li><p>If <var>continue</var> is false, then abort these steps.
<li><p>If <var>continue</var> is false, then return.</p></li>

<li><p>If <var>form</var> <span>cannot navigate</span>, then return.</p></li>

This comment has been minimized.

Copy link
@domenic

domenic Aug 24, 2017

Member

Should we expand the HTML comment here into a visible note?

This comment has been minimized.

Copy link
@annevk

annevk Aug 25, 2017

Author Member

I guess we could.

@@ -22935,11 +22922,23 @@ interface <dfn>HTMLHyperlinkElementUtils</dfn> {

<h4>Following hyperlinks</h4>

<p>An element <var>element</var> <dfn>cannot navigate</dfn> if one of the following is true:</p>

This comment has been minimized.

Copy link
@domenic

domenic Aug 24, 2017

Member

This section is full of double negatives ("an element cannot navigate if it's node document is not fully active"), but I think it's pretty nice at the call sites, so I'm not sure what to do. I guess you could define "can navigate" and then say "cannot navigate = the negation of can navigate".

This comment has been minimized.

Copy link
@annevk

annevk Aug 25, 2017

Author Member

I'd rather just leave it as-is unless we get more complaints. Or until we turn everything into abstract operations, if ever.

@@ -22935,11 +22922,23 @@ interface <dfn>HTMLHyperlinkElementUtils</dfn> {

<h4>Following hyperlinks</h4>

<p>An element <var>element</var> <dfn>cannot navigate</dfn> if one of the following is true:</p>

This comment has been minimized.

Copy link
@domenic

domenic Aug 24, 2017

Member

FYI https://english.stackexchange.com/questions/204006/cannot-vs-can-not since my brain momentarily started thinking "cannot" is weird. (TLDR: it's correct.)

@domenic

This comment has been minimized.

Copy link
Member

commented Aug 24, 2017

Can we also get tests for both locations in the form algorithm?

@annevk

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2017

Made the note visible.

@annevk

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2017

Updated tests too.

@annevk

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2017

annevk added a commit to web-platform-tests/wpt that referenced this pull request Sep 22, 2017
Follow-up tests for whatwg/html#2613.
@annevk annevk merged commit f3c354a into master Sep 22, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@annevk annevk deleted the annevk/simplify-a-area-link branch Sep 22, 2017
rachelandrew added a commit to rachelandrew/web-platform-tests that referenced this pull request Nov 8, 2017
jakearchibald added a commit to jakearchibald/web-platform-tests that referenced this pull request Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.