Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling to fragments #2901

Merged
merged 2 commits into from Aug 19, 2017
Merged

Fix scrolling to fragments #2901

merged 2 commits into from Aug 19, 2017

Conversation

@annevk
Copy link
Member

@annevk annevk commented Aug 10, 2017

Chrome and Safari both do a literal match first before using the decoded fragment. Edge does something very similar, though seems to differ in :target handling. Firefox would like to align per https://bugzilla.mozilla.org/show_bug.cgi?id=1380323 as our compliant behavior causes issues.

Tests: ...

@annevk
Copy link
Member Author

@annevk annevk commented Aug 16, 2017

This now has tests at web-platform-tests/wpt#6887 written by @alphan102.

@tkent-google would you be willing to review?

Copy link
Collaborator

@tkent-google tkent-google left a comment

Looks good to me.

@annevk
Copy link
Member Author

@annevk annevk commented Aug 17, 2017

@zcorpan willing to do editorial review and tests?

annevk added a commit to web-platform-tests/wpt that referenced this issue Aug 17, 2017
@annevk
Copy link
Member Author

@annevk annevk commented Aug 17, 2017

We should probably hold off merging this until we figure out how to deploy without hitting DreamHost limits (assuming that's the problem, which I'm not sure about).

annevk added 2 commits Aug 19, 2017
Chrome and Safari both do a literal match first before using the decoded fragment. Edge does something very similar, though seems to differ in :target handling. Firefox would like to align per https://bugzilla.mozilla.org/show_bug.cgi?id=1380323 as our compliant behavior causes issues.

Tests: ...
@annevk annevk force-pushed the annevk/indicated-part-of-the-document branch from 8e78536 to fc787f5 Aug 19, 2017
@annevk annevk merged commit c230f55 into master Aug 19, 2017
1 check passed
@annevk annevk deleted the annevk/indicated-part-of-the-document branch Aug 19, 2017
rachelandrew added a commit to rachelandrew/web-platform-tests that referenced this issue Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants