Skip to content

Fix scrolling to fragments#2901

Merged
annevk merged 2 commits intomasterfrom
annevk/indicated-part-of-the-document
Aug 19, 2017
Merged

Fix scrolling to fragments#2901
annevk merged 2 commits intomasterfrom
annevk/indicated-part-of-the-document

Conversation

@annevk
Copy link
Member

@annevk annevk commented Aug 10, 2017

Chrome and Safari both do a literal match first before using the decoded fragment. Edge does something very similar, though seems to differ in :target handling. Firefox would like to align per https://bugzilla.mozilla.org/show_bug.cgi?id=1380323 as our compliant behavior causes issues.

Tests: ...

@annevk
Copy link
Member Author

annevk commented Aug 16, 2017

This now has tests at web-platform-tests/wpt#6887 written by @alphan102.

@tkent-google would you be willing to review?

Copy link
Contributor

@tkent-google tkent-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@annevk
Copy link
Member Author

annevk commented Aug 17, 2017

@zcorpan willing to do editorial review and tests?

annevk pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 17, 2017
@annevk
Copy link
Member Author

annevk commented Aug 17, 2017

We should probably hold off merging this until we figure out how to deploy without hitting DreamHost limits (assuming that's the problem, which I'm not sure about).

annevk added 2 commits August 19, 2017 08:58
Chrome and Safari both do a literal match first before using the decoded fragment. Edge does something very similar, though seems to differ in :target handling. Firefox would like to align per https://bugzilla.mozilla.org/show_bug.cgi?id=1380323 as our compliant behavior causes issues.

Tests: ...
@annevk annevk force-pushed the annevk/indicated-part-of-the-document branch from 8e78536 to fc787f5 Compare August 19, 2017 06:58
@annevk annevk merged commit c230f55 into master Aug 19, 2017
@annevk annevk deleted the annevk/indicated-part-of-the-document branch August 19, 2017 07:02
rachelandrew pushed a commit to rachelandrew/web-platform-tests that referenced this pull request Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants