Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix module script error handling, again #2991
Recent investigation determined more problems with the module script
This revision avoids all these problems. The strategy is essentially:
To implement this strategy, a new "error to rethrow" field was
Note that with this strategy we no longer inspect the [[Status]] or
This will need some tests to exercise those cases we discovered, as well as the slightly-changed error identity behavior that comes from not recording errors as aggressively. We plan to write those as part of Blink updating to this.
Preview version at https://output-osunnkiurv.now.sh
Using script's error in two different ways looks confusing for me.
How about introducing a new field for Use Case 2, while keeping the field for Use Case 1 as parse error?
Separation of these two uses is ensured by relatively subtle aspects of the spec, i.e.