Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap the words “pick” and “toggle” (§ 4.11.3 “Commands”) #3072

Merged
merged 1 commit into from Sep 27, 2017

Conversation

delan
Copy link
Contributor

@delan delan commented Sep 26, 2017

The old text associates “pick” with <select multiple> elements and “toggle” with other <select> elements [0], but the defining instances of “pick” [1] and “toggle” [2] make the converse association.

  1. “If the […]” in § 4.11.3.5 “Using the <option> element to define a command”
  2. “picked” in § 4.10.7 “The <select> element”
  3. “toggle” in § 4.10.7 “The <select> element”

The old text associates “pick” with <select multiple> elements and
“toggle” with other <select> elements [0], but the defining instances
of “pick” [1] and “toggle” [2] make the converse association.

[0] § 4.11.3.5 “Using the <option> element to define a command” <https
://html.spec.whatwg.org/multipage/interactive-elements.html#using-the-
option-element-to-define-a-command>

[1] “picked” in § 4.10.7 “The <select> element” <https://html.spec.wha
twg.org/multipage/form-elements.html#concept-select-pick>

[2] “toggle” in § 4.10.7 “The <select> element” <https://html.spec.wha
twg.org/multipage/form-elements.html#concept-select-toggle>
annevk
annevk approved these changes Sep 27, 2017
@annevk annevk merged commit 75cce62 into whatwg:master Sep 27, 2017
@annevk
Copy link
Member

annevk commented Sep 27, 2017

Great catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants