Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a domintro block for WebSocket interface #3159

Merged
merged 3 commits into from Oct 27, 2017

Conversation

2 participants
@sideshowbarker
Copy link
Member

sideshowbarker commented Oct 26, 2017

This change adds a domintro block in the section that defines the WebSocket
interface and also the section that defines the CloseEvent interface.
Additionally, it adds markup to cause more implementor-specific parts of the
“Web sockets” section of the spec to be supressed in the developer edition.

sideshowbarker and others added some commits Oct 26, 2017

Add a domintro block for WebSocket interface
This change adds a domintro block in the section that defines the WebSocket
interface and also the section that defines the CloseEvent interface.
Additionally, it adds markup to cause more implementor-specific parts of the
“Web sockets” section of the spec to be supressed in the developer edition.
@domenic
Copy link
Member

domenic left a comment

Wow, very nice find; thank you. I made a few tweaks; let me know what you think.

@sideshowbarker
Copy link
Member Author

sideshowbarker left a comment

These changes looks great — thanks!

@sideshowbarker
Copy link
Member Author

sideshowbarker left a comment

Thanks — these changes also LGTM

@domenic domenic merged commit 4ea65dc into master Oct 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@domenic domenic deleted the sideshowbarker/websockets-section-add-domintro branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.