New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ.md #3231

Closed
wants to merge 3 commits into
base: master
from

Conversation

3 participants
@shreyateeza
Member

shreyateeza commented Nov 16, 2017

Please change 'implementor' to 'implementer'.

shreyateeza added some commits Nov 5, 2017

End Body tag missing
Please add end body tag (</body>)
<html> tags missing
Starting and ending html tags are missing.
Update FAQ.md
Change 'implementor' to implementer.
@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Nov 16, 2017

Member

Thanks, could you please drop the changes to the 404.html resource?

Member

annevk commented Nov 16, 2017

Thanks, could you please drop the changes to the 404.html resource?

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Nov 16, 2017

Member

We use "implementor" (which is also correct spelling) across most of the WHATWG I think. As such I think this should be closed.

Member

domenic commented Nov 16, 2017

We use "implementor" (which is also correct spelling) across most of the WHATWG I think. As such I think this should be closed.

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Nov 16, 2017

Member

If that's the case let's specify that in https://wiki.whatwg.org/wiki/Style. We seem to use -er in /faq, /working-mode, some places in html/source, html/FAQ.md, ecma262/spec.html, ...

Member

annevk commented Nov 16, 2017

If that's the case let's specify that in https://wiki.whatwg.org/wiki/Style. We seem to use -er in /faq, /working-mode, some places in html/source, html/FAQ.md, ecma262/spec.html, ...

@shreyateeza

This comment has been minimized.

Show comment
Hide comment
@shreyateeza

shreyateeza Nov 16, 2017

Member

@annevk I will surely drop the changes to 404.html. But I don't know how to do it. It would be great if you will tell me.

Member

shreyateeza commented Nov 16, 2017

@annevk I will surely drop the changes to 404.html. But I don't know how to do it. It would be great if you will tell me.

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Nov 16, 2017

Member

@shreyateeza if you do git rebase -i HEAD~N where N is the number of commits (3 here I suppose) you can edit your commits, including dropping them. You can then do git push --force to push your revised commits to this PR.

Having said that, it seems like instead of going for -er, we'd like to go for implementor everywhere, so that would need to change as well.

Member

annevk commented Nov 16, 2017

@shreyateeza if you do git rebase -i HEAD~N where N is the number of commits (3 here I suppose) you can edit your commits, including dropping them. You can then do git push --force to push your revised commits to this PR.

Having said that, it seems like instead of going for -er, we'd like to go for implementor everywhere, so that would need to change as well.

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Nov 17, 2017

Member

@domenic how sure are you that -or is correct? It has far fewer hits on Google, it's also developer/programmer, and I can't really find a good authoritative source on the matter.

Member

annevk commented Nov 17, 2017

@domenic how sure are you that -or is correct? It has far fewer hits on Google, it's also developer/programmer, and I can't really find a good authoritative source on the matter.

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Nov 17, 2017

Member

I'm not sure at all; I was just under the impression that's what we used more often. Notably HTML prefers it (with some inconsistency, presumably introduced by us post-Hixie) and that's what we used for the "needs implementor interest" label. I'm happy to switch, as long as we do it globally.

Member

domenic commented Nov 17, 2017

I'm not sure at all; I was just under the impression that's what we used more often. Notably HTML prefers it (with some inconsistency, presumably introduced by us post-Hixie) and that's what we used for the "needs implementor interest" label. I'm happy to switch, as long as we do it globally.

annevk added a commit that referenced this pull request Nov 17, 2017

@annevk annevk closed this in #3237 Nov 20, 2017

annevk added a commit that referenced this pull request Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment