Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing link rel=serviceworker for now. #3233

Merged
merged 2 commits into from Nov 22, 2017

Conversation

3 participants
@jakearchibald
Copy link
Collaborator

jakearchibald commented Nov 16, 2017

This is being removed as part of foreign fetch, but we may add it again once we have a better understanding of the use cases.

Removing link rel=serviceworker for now.
This is being removed as part of foreign fetch, but we may add it again once we have a better understanding of the use cases.
@annevk

This comment has been minimized.

Copy link
Member

annevk commented Nov 17, 2017

This looks like a rough reversal of c5d4f5c (we should mention that in the final commit message I think).

@sideshowbarker can you take a look since you added this?

@annevk

This comment has been minimized.

Copy link
Member

annevk commented Nov 22, 2017

Are there tests that need to be removed? Anything to reference in the commit message other than w3c/ServiceWorker#1207?

@annevk

This comment has been minimized.

Copy link
Member

annevk commented Nov 22, 2017

Perhaps we need a negative test or was this never implemented anywhere?

@jakearchibald

This comment has been minimized.

Copy link
Collaborator Author

jakearchibald commented Nov 22, 2017

I removed the tests in web-platform-tests/wpt#7762.

Do we usually do negative tests for things like this? It's in Chrome but behind a flag.

jakearchibald added a commit to web-platform-tests/wpt that referenced this pull request Nov 22, 2017

@annevk

This comment has been minimized.

Copy link
Member

annevk commented Nov 22, 2017

It depends a bit on how long it's been around. If it's only behind a flag we probably don't need any.

@annevk annevk merged commit 52d09c9 into master Nov 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the remove-link-rel-serviceworker branch Nov 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.