Move _charset_ handling from "multipart/form-data encoding algorithm"… #3645
Conversation
… and "text/plain encoding algorithm" to "construct the form data set" algorithm The updated algorithms match to Chrome, Firefox, and Safari. This fixes whatwg#3560.
HTML spec change: whatwg/html#3645 URL spec change: whatwg/url#382
|
URL spec: whatwg/url#382 |
source
Outdated
| element whose <code data-x="attr-input-type">type</code> attribute is in | ||
| the <span data-x="attr-input-type-hidden">Hidden</span> state and | ||
| <var>name</var> is "<code data-x="attr-fe-name-charset">_charset_</code>": | ||
| </p> |
There was a problem hiding this comment.
This </p> needs to be on the previous line. Some rewrapping to account for 100 columns might also be needed. I'm happy to help with that.
source
Outdated
| <ol> | ||
| <li><p>Let <var>charset</var> be the <span data-x="encoding name">name | ||
| </span> of <var>encoding</var> if <var>encoding</var> is specified, be | ||
| "<code data-x="">UTF-8</code>" otherwise.</p></li> |
There was a problem hiding this comment.
if encoding is given*
and "UTF-8" otherwise*
source
Outdated
| "<code data-x="">UTF-8</code>" otherwise.</p></li> | ||
|
|
||
| <li><p>Append an entry to the <var>form data set</var> with <var>name | ||
| </var> as the name, <var>charset</var> as the value, and <var>type</var> |
There was a problem hiding this comment.
No newlines inside inline elements.
Done.
I think keeping file-specific handling in each of form encodings would make introducing |
|
That makes a lot of sense. |
|
@tkent-google I pushed a formatting nits commit and another commit to align your Acknowledgments line with what you have for URL. Hope that's okay, can revert if you want. |
That's ok. Thank you! |
HTML change: whatwg/html#3645. URL change: whatwg/url#382.
Automatic update from web-platform-testsHTML: form's _charset_ handling HTML change: whatwg/html#3645. URL change: whatwg/url#382. -- wpt-commits: c70b18e9e43e3a41f6988a2a1f88d84b01a3dfcc wpt-pr: 10623
Automatic update from web-platform-testsHTML: form's _charset_ handling HTML change: whatwg/html#3645. URL change: whatwg/url#382. -- wpt-commits: c70b18e9e43e3a41f6988a2a1f88d84b01a3dfcc wpt-pr: 10623 UltraBlame original commit: bfc1a530e1c8cc210e2ad9fc866c3caeb4b2ec4d
Automatic update from web-platform-testsHTML: form's _charset_ handling HTML change: whatwg/html#3645. URL change: whatwg/url#382. -- wpt-commits: c70b18e9e43e3a41f6988a2a1f88d84b01a3dfcc wpt-pr: 10623 UltraBlame original commit: bfc1a530e1c8cc210e2ad9fc866c3caeb4b2ec4d
Automatic update from web-platform-testsHTML: form's _charset_ handling HTML change: whatwg/html#3645. URL change: whatwg/url#382. -- wpt-commits: c70b18e9e43e3a41f6988a2a1f88d84b01a3dfcc wpt-pr: 10623 UltraBlame original commit: bfc1a530e1c8cc210e2ad9fc866c3caeb4b2ec4d
… and "text/plain encoding algorithm" to "construct the form data set" algorithm
The updated algorithms match to Chrome, Firefox, and Safari.
This fixes #3560.
/acknowledgements.html ( diff )
/form-control-infrastructure.html ( diff )