Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move _charset_ handling from "multipart/form-data encoding algorithm"… #3645

Merged
merged 4 commits into from Apr 27, 2018

Conversation

@tkent-google
Copy link
Collaborator

tkent-google commented Apr 25, 2018

… and "text/plain encoding algorithm" to "construct the form data set" algorithm

The updated algorithms match to Chrome, Firefox, and Safari.

This fixes #3560.


/acknowledgements.html ( diff )
/form-control-infrastructure.html ( diff )

… and "text/plain encoding algorithm" to "construct the form data set" algorithm

The updated algorithms match to Chrome, Firefox, and Safari.

This fixes #3560.
tkent-google added a commit to web-platform-tests/wpt that referenced this pull request Apr 25, 2018
HTML spec change: whatwg/html#3645
URL spec change: whatwg/url#382
@tkent-google
Copy link
Collaborator Author

tkent-google commented Apr 25, 2018

Copy link
Member

annevk left a comment

The text/plain encoding algorithm no longer needs its encoding parameter due to this change. We should remove it.

Thoughts on doing this for <input type=file>? I guess it makes less sense given the three encodings actually encode that differently.

source Outdated
element whose <code data-x="attr-input-type">type</code> attribute is in
the <span data-x="attr-input-type-hidden">Hidden</span> state and
<var>name</var> is "<code data-x="attr-fe-name-charset">_charset_</code>":
</p>

This comment has been minimized.

@annevk

annevk Apr 25, 2018 Member

This </p> needs to be on the previous line. Some rewrapping to account for 100 columns might also be needed. I'm happy to help with that.

This comment has been minimized.

@tkent-google

tkent-google Apr 27, 2018 Author Collaborator

Done.

source Outdated
<ol>
<li><p>Let <var>charset</var> be the <span data-x="encoding name">name
</span> of <var>encoding</var> if <var>encoding</var> is specified, be
"<code data-x="">UTF-8</code>" otherwise.</p></li>

This comment has been minimized.

@annevk

annevk Apr 25, 2018 Member

if encoding is given*

and "UTF-8" otherwise*

This comment has been minimized.

@tkent-google

tkent-google Apr 27, 2018 Author Collaborator

Done.

source Outdated
"<code data-x="">UTF-8</code>" otherwise.</p></li>

<li><p>Append an entry to the <var>form data set</var> with <var>name
</var> as the name, <var>charset</var> as the value, and <var>type</var>

This comment has been minimized.

@annevk

annevk Apr 25, 2018 Member

No newlines inside inline elements.

This comment has been minimized.

@tkent-google

tkent-google Apr 27, 2018 Author Collaborator

Done.

@tkent-google
Copy link
Collaborator Author

tkent-google commented Apr 27, 2018

The text/plain encoding algorithm no longer needs its encoding parameter due to this change. We should remove it.

Done.

Thoughts on doing this for ? I guess it makes less sense given the three encodings actually encode that differently.

I think keeping file-specific handling in each of form encodings would make introducing formdata event easier because an event handler may add files.

@annevk
Copy link
Member

annevk commented Apr 27, 2018

That makes a lot of sense.

annevk added 2 commits Apr 27, 2018
@annevk
Copy link
Member

annevk commented Apr 27, 2018

@tkent-google I pushed a formatting nits commit and another commit to align your Acknowledgments line with what you have for URL. Hope that's okay, can revert if you want.

@tkent-google
Copy link
Collaborator Author

tkent-google commented Apr 27, 2018

I pushed a formatting nits commit and another commit to align your Acknowledgments line with what you have for URL. Hope that's okay, can revert if you want.

That's ok. Thank you!

@annevk
annevk approved these changes Apr 27, 2018
annevk added a commit to web-platform-tests/wpt that referenced this pull request Apr 27, 2018
HTML change: whatwg/html#3645.

URL change: whatwg/url#382.
@annevk annevk merged commit 8c212e5 into whatwg:master Apr 27, 2018
2 checks passed
2 checks passed
Participation tkent-google participates on behalf of Google LLC
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 2, 2018
Automatic update from web-platform-testsHTML: form's _charset_ handling

HTML change: whatwg/html#3645.

URL change: whatwg/url#382.
--

wpt-commits: c70b18e9e43e3a41f6988a2a1f88d84b01a3dfcc
wpt-pr: 10623
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 2, 2019
Automatic update from web-platform-testsHTML: form's _charset_ handling

HTML change: whatwg/html#3645.

URL change: whatwg/url#382.
--

wpt-commits: c70b18e9e43e3a41f6988a2a1f88d84b01a3dfcc
wpt-pr: 10623

UltraBlame original commit: bfc1a530e1c8cc210e2ad9fc866c3caeb4b2ec4d
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
Automatic update from web-platform-testsHTML: form's _charset_ handling

HTML change: whatwg/html#3645.

URL change: whatwg/url#382.
--

wpt-commits: c70b18e9e43e3a41f6988a2a1f88d84b01a3dfcc
wpt-pr: 10623

UltraBlame original commit: bfc1a530e1c8cc210e2ad9fc866c3caeb4b2ec4d
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
Automatic update from web-platform-testsHTML: form's _charset_ handling

HTML change: whatwg/html#3645.

URL change: whatwg/url#382.
--

wpt-commits: c70b18e9e43e3a41f6988a2a1f88d84b01a3dfcc
wpt-pr: 10623

UltraBlame original commit: bfc1a530e1c8cc210e2ad9fc866c3caeb4b2ec4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.