New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move _charset_ handling from "multipart/form-data encoding algorithm"… #3645

Merged
merged 4 commits into from Apr 27, 2018

Conversation

2 participants
@tkent-google
Contributor

tkent-google commented Apr 25, 2018

… and "text/plain encoding algorithm" to "construct the form data set" algorithm

The updated algorithms match to Chrome, Firefox, and Safari.

This fixes #3560.


/acknowledgements.html ( diff )
/form-control-infrastructure.html ( diff )

Move _charset_ handling from "multipart/form-data encoding algorithm"…
… and "text/plain encoding algorithm" to "construct the form data set" algorithm

The updated algorithms match to Chrome, Firefox, and Safari.

This fixes #3560.

tkent-google added a commit to web-platform-tests/wpt that referenced this pull request Apr 25, 2018

@tkent-google

This comment has been minimized.

Show comment
Hide comment
@tkent-google
Contributor

tkent-google commented Apr 25, 2018

@annevk

The text/plain encoding algorithm no longer needs its encoding parameter due to this change. We should remove it.

Thoughts on doing this for <input type=file>? I guess it makes less sense given the three encodings actually encode that differently.

Show outdated Hide outdated source
Show outdated Hide outdated source
Show outdated Hide outdated source
@tkent-google

This comment has been minimized.

Show comment
Hide comment
@tkent-google

tkent-google Apr 27, 2018

Contributor

The text/plain encoding algorithm no longer needs its encoding parameter due to this change. We should remove it.

Done.

Thoughts on doing this for ? I guess it makes less sense given the three encodings actually encode that differently.

I think keeping file-specific handling in each of form encodings would make introducing formdata event easier because an event handler may add files.

Contributor

tkent-google commented Apr 27, 2018

The text/plain encoding algorithm no longer needs its encoding parameter due to this change. We should remove it.

Done.

Thoughts on doing this for ? I guess it makes less sense given the three encodings actually encode that differently.

I think keeping file-specific handling in each of form encodings would make introducing formdata event easier because an event handler may add files.

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Apr 27, 2018

Member

That makes a lot of sense.

Member

annevk commented Apr 27, 2018

That makes a lot of sense.

annevk added some commits Apr 27, 2018

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Apr 27, 2018

Member

@tkent-google I pushed a formatting nits commit and another commit to align your Acknowledgments line with what you have for URL. Hope that's okay, can revert if you want.

Member

annevk commented Apr 27, 2018

@tkent-google I pushed a formatting nits commit and another commit to align your Acknowledgments line with what you have for URL. Hope that's okay, can revert if you want.

@tkent-google

This comment has been minimized.

Show comment
Hide comment
@tkent-google

tkent-google Apr 27, 2018

Contributor

I pushed a formatting nits commit and another commit to align your Acknowledgments line with what you have for URL. Hope that's okay, can revert if you want.

That's ok. Thank you!

Contributor

tkent-google commented Apr 27, 2018

I pushed a formatting nits commit and another commit to align your Acknowledgments line with what you have for URL. Hope that's okay, can revert if you want.

That's ok. Thank you!

@annevk

annevk approved these changes Apr 27, 2018

annevk added a commit to web-platform-tests/wpt that referenced this pull request Apr 27, 2018

@annevk annevk merged commit 8c212e5 into whatwg:master Apr 27, 2018

2 checks passed

Participation tkent-google participates on behalf of Google LLC
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 2, 2018

Bug 1456707 [wpt PR 10623] - html: Add a test for _charset_., a=testonly
Automatic update from web-platform-testsHTML: form's _charset_ handling

HTML change: whatwg/html#3645.

URL change: whatwg/url#382.
--

wpt-commits: c70b18e9e43e3a41f6988a2a1f88d84b01a3dfcc
wpt-pr: 10623

mykmelez pushed a commit to mozilla/gecko that referenced this pull request May 3, 2018

Bug 1456707 [wpt PR 10623] - html: Add a test for _charset_., a=testonly
Automatic update from web-platform-testsHTML: form's _charset_ handling

HTML change: whatwg/html#3645.

URL change: whatwg/url#382.
--

wpt-commits: c70b18e9e43e3a41f6988a2a1f88d84b01a3dfcc
wpt-pr: 10623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment