Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Define the ACHL cache and ACHL/ACH processing #3774
This initial PR still doesn't resolve everything that was previously discussed (e.g. doesn't clear the ACHL cache along with cookies just yet), but I'd love to get an early opinion on it, to see if this is the right direction.
/browsing-the-web.html ( diff )
This was referenced
Jun 26, 2018
(Continuing this discussion away from now-collapsed commit comments:)
It could make sense, but as written doesn't really work. Every time you say "some settings object's client-hints set", you run the algorithm specified in https://whatpr.org/html/3774/window-object.html#script-settings-for-window-objects , which re-creates a new list from scratch. So any additions you make to it (via Accept-CH) are only to that list, and are never seen again by any future callers of "some settings object's client-hints set".
If you want a single list that's created once, and then stored and returned later, you need to explicitly do that.
Relatedly, it seems a bit strange that you intend to create one client hints set per environment settings object (<-> Window), whereas all the other similar stuff like origin, HTTPS state, and referrer policy are associated with the Document. The main difference here is how you treat the transition from initial about:blank to a new Document within the same window. As written right now, if I add
I'd thus suggest a framework that more closely follows referrer policy or HTTPS state:
Then I think this would work:
OK, I did a pass through for a final review that was mostly editorial. Please check my changes and let me know what you think.
I'd still prefer to hold off on this until @annevk has time to look at it from a higher conceptual/architectural. But, I think it's pretty solid at the level that I can understand.