Specify -webkit-appearance: fieldset and legend: auto #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO explain what this does. Fixes #3912 (TODO more issues).
zcorpan
added
do not merge yet
|
Need to go through and address/respond to feedback in w3c/csswg-drafts#3094 as part of this PR. |
This comment was marked as resolved.
This comment was marked as resolved.
8 tasks
|
@zcorpan any interest in picking this back up again? cc @whatwg/forms |
|
No, per w3c/csswg-drafts#3094 (comment) using |
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define fieldset's rendering in terms of a new 'webkit-appearance' value, so that web developers can turn off the "magic".
Fixes #3912
This is on top of #3934
Per discussion in w3c/csswg-drafts#3094 this is likely to change to use a different approach.
Tests:
web-platform-tests/wpt#12677
web-platform-tests/wpt#12940
(Also see commit web-platform-tests/wpt@f8d9bc2 in web-platform-tests/wpt#12691 )
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Jan 15, 2021, 7:58 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.