Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify -webkit-appearance: fieldset and legend: auto #4035

Closed
wants to merge 37 commits into from

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Sep 14, 2018

Define fieldset's rendering in terms of a new 'webkit-appearance' value, so that web developers can turn off the "magic".

Fixes #3912

This is on top of #3934

Per discussion in w3c/csswg-drafts#3094 this is likely to change to use a different approach.

Tests:
web-platform-tests/wpt#12677
web-platform-tests/wpt#12940
(Also see commit web-platform-tests/wpt@f8d9bc2 in web-platform-tests/wpt#12691 )


馃挜 Error: Wattsi server error 馃挜

PR Preview failed to build. (Last tried on Jan 15, 2021, 7:58 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

馃毃 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

馃敆 Related URL

Command failed: /home/noderunner/wattsi/bin/wattsi /tmp/upload_749a7af7bff3a4a4cdde4f710aa1e318 (sha not provided) 554r7nybaq5 default /tmp/upload_423c1e6ecb86c7f8a10df48d726e6e87

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

TODO explain what this does.

Fixes #3912 (TODO more issues).
@zcorpan zcorpan added do not merge yet Pull request must not be merged per rationale in comment topic: fieldset labels Sep 14, 2018
@zcorpan zcorpan added addition/proposal New features or enhancements topic: rendering labels Sep 14, 2018
@zcorpan
Copy link
Member Author

zcorpan commented Sep 14, 2018

Need to go through and address/respond to feedback in w3c/csswg-drafts#3094 as part of this PR.

@annevk

This comment has been hidden.

@annevk
Copy link
Member

annevk commented Mar 18, 2023

@zcorpan any interest in picking this back up again?

cc @whatwg/forms

@zcorpan
Copy link
Member Author

zcorpan commented Mar 20, 2023

No, per w3c/csswg-drafts#3094 (comment) using appearance to describe fieldset is not what we want. There's no new proposal though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements do not merge yet Pull request must not be merged per rationale in comment topic: fieldset topic: rendering
Development

Successfully merging this pull request may close these issues.

Disable fieldset/legend rendering magic with CSS
2 participants