Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move optional param to be on PostMessageOptions dictionary instead of transfer. #4138

Merged
merged 1 commit into from Oct 30, 2018

Conversation

@dtapuska
Copy link
Contributor

commented Oct 29, 2018

Fixes #4137

@dtapuska dtapuska changed the title Move optional field to be on dictionary instead of transfer. Move optional param to be on PostMessageOptions dictionary instead of transfer. Oct 29, 2018

@dtapuska

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2018

@annevk

This comment has been minimized.

Copy link
Member

commented Oct 29, 2018

Thanks, seems like we should also update the domintro boxes following these and no longer mark the argument as optional there, although in practice I guess it remains optional. Hmm. @domenic?

@domenic

This comment has been minimized.

Copy link
Member

commented Oct 29, 2018

I wouldn't change the domintro boxes; they're informative summaries, not in 1:1 correspondence with the IDL.

@annevk
annevk approved these changes Oct 30, 2018
Copy link
Member

left a comment

It's not entirely clear if we also need wpt updates here. I guess the IDL will update automatically?

@dtapuska

This comment has been minimized.

Copy link
Contributor Author

commented Oct 30, 2018

They get automatically extracted from the spec into: https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl and then there is a job that imports them into wpt. Although it seems to run periodically and not on a trigger.

@annevk annevk merged commit e3f1cc8 into whatwg:master Oct 30, 2018

2 checks passed

Participation dtapuska participates on behalf of Google LLC
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@annevk

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

Thanks @dtapuska!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.