Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event-based form participation #4239

Merged
merged 4 commits into from Jan 8, 2019

Conversation

@tkent-google
Copy link
Collaborator

commented Dec 14, 2018

  • Add formdata event and FormDataEvent interface
  • Fire it in "constructing the entry list" algorithm
  • Introduce "constructing entry list" flag of a form element to avoid
    recursive submission.

This fixes a part of w3c/webcomponents#187

XHR specification PR: whatwg/xhr#231
Test: web-platform-tests/wpt#14637


/form-control-infrastructure.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/webappapis.html ( diff )

- Add formdata event and FormDataEvent interface
- Fire it in "constructing the entry list" algorithm
- Introduce "constructing entry list" flag of a form element to avoid
  recursive submission.

This fixes a part of w3c/webcomponents#187
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 17, 2018
…ated by "new FormData(form)"

Specification: whatwg/html#4239

Bug: 825684
Bug: w3c/webcomponents#187
Change-Id: I4213d9a1b3b8081f421ab89529421d28cfc322f0
Reviewed-on: https://chromium-review.googlesource.com/c/1379599
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617067}
Copy link
Member

left a comment

This looks great! It's nice that the spec ended up being so simple.

I had some review nits, but since it took me 6 days to review anyway, I just pushed them as a separate commit, instead of doing a round trip.

I think you have some web platform tests for this ready to upstream, right? Can you link to them?

From what I recall everyone was excited about this at the web components F2F. Do folks want to give it a look to ensure the final spec meets their needs? @rniwa / @hober; @travisleithead; @annevk / @smaug---- ?

tkent-google added a commit to web-platform-tests/wpt that referenced this pull request Dec 21, 2018
Specification PR: whatwg/html#4239
tkent-google added a commit to tkent-google/xhr that referenced this pull request Dec 21, 2018
@tkent-google

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 21, 2018

Here is the test PR: web-platform-tests/wpt#14637

Copy link
Member

left a comment

Thanks for writing this up, looks solid overall, but we do need to add an event constructor here I think.

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@tkent-google

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 7, 2019

Will update the WPT PR for FormDataEvent constructor.

source Show resolved Hide resolved
annevk added a commit to web-platform-tests/wpt that referenced this pull request Jan 8, 2019
@annevk
annevk approved these changes Jan 8, 2019
Copy link
Member

left a comment

Great, thanks! @domenic want to look again? I'd prefer waiting with landing this until we can land wpt. I pinged the wpt IRC channel to see if anyone has insights into the failure.

As per https://github.com/whatwg/meta/blob/master/MAINTAINERS.md#handling-pull-requests we'll also need implementation bugs for this to ensure everyone knows this is going on.

jgraham added a commit to web-platform-tests/wpt that referenced this pull request Jan 8, 2019
@annevk

This comment has been minimized.

Copy link
Member

commented Jan 8, 2019

This and whatwg/xhr#231 can be landed modulo implementation bugs. wpt is sorted.

@annevk annevk merged commit 1375c0c into whatwg:master Jan 8, 2019
2 checks passed
2 checks passed
Participation tkent-google participates on behalf of Google LLC
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
annevk added a commit to whatwg/xhr that referenced this pull request Jan 8, 2019
@jdm jdm referenced this pull request Jan 8, 2019
@annevk

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

I now wonder if we should have done something here like make a copy of the data or some such, to make it clear at which point mutations to FormData no longer matter. I think that's what implementations do, so we probably need to add that?

@tkent-google

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 11, 2019

I now wonder if we should have done something here like make a copy of the data or some such, to make it clear at which point mutations to FormData no longer matter. I think that's what implementations do, so we probably need to add that?

Yeah, with the current specification, a formData attribute of a FormDataEvent and the resultant instance of new FormData(form) look to share a single entry list. We should copy the list after the event. I'll make a PR for it.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 5, 2019
…t, a=testonly

Automatic update from web-platform-tests
html, xhr: Add tests for 'formdata' event (#14637)

Specification PR: whatwg/html#4239

--

wpt-commits: c547389199647f1736be244a7ca5a874da692430
wpt-pr: 14637
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 6, 2019
…t, a=testonly

Automatic update from web-platform-tests
html, xhr: Add tests for 'formdata' event (#14637)

Specification PR: whatwg/html#4239

--

wpt-commits: c547389199647f1736be244a7ca5a874da692430
wpt-pr: 14637
@tkent-google tkent-google referenced this pull request Feb 7, 2019
3 of 5 tasks complete
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 7, 2019
…t, a=testonly

Automatic update from web-platform-tests
html, xhr: Add tests for 'formdata' event (#14637)

Specification PR: whatwg/html#4239

--

wpt-commits: c547389199647f1736be244a7ca5a874da692430
wpt-pr: 14637
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 8, 2019
…t, a=testonly

Automatic update from web-platform-tests
html, xhr: Add tests for 'formdata' event (#14637)

Specification PR: whatwg/html#4239

--

wpt-commits: c547389199647f1736be244a7ca5a874da692430
wpt-pr: 14637
tkent-google added a commit to tkent-google/html that referenced this pull request Mar 8, 2019
This is a follow-up of whatwg#4239, and
fixes an issue pointed out in web-platform-tests/wpt#14637
domenic added a commit that referenced this pull request Mar 8, 2019
This is a follow-up of #4239, and
fixes an issue pointed out in web-platform-tests/wpt#14637.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 6, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

--HG--
extra : moz-landing-system : lando
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Sep 7, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 7, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

--HG--
extra : moz-landing-system : lando
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Sep 7, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986
bdekoz pushed a commit to bdekoz/gecko that referenced this pull request Sep 9, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 9, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

--HG--
extra : moz-landing-system : lando
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…t, a=testonly

Automatic update from web-platform-tests
html, xhr: Add tests for 'formdata' event (#14637)

Specification PR: whatwg/html#4239

--

wpt-commits: c547389199647f1736be244a7ca5a874da692430
wpt-pr: 14637

UltraBlame original commit: c71f7d3fa10b69185c90a1537bb49989a0fd4604
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…t, a=testonly

Automatic update from web-platform-tests
html, xhr: Add tests for 'formdata' event (#14637)

Specification PR: whatwg/html#4239

--

wpt-commits: c547389199647f1736be244a7ca5a874da692430
wpt-pr: 14637

UltraBlame original commit: c0fe813241a5041aec5fd25054a003016720745c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…t, a=testonly

Automatic update from web-platform-tests
html, xhr: Add tests for 'formdata' event (#14637)

Specification PR: whatwg/html#4239

--

wpt-commits: c547389199647f1736be244a7ca5a874da692430
wpt-pr: 14637

UltraBlame original commit: c71f7d3fa10b69185c90a1537bb49989a0fd4604
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…t, a=testonly

Automatic update from web-platform-tests
html, xhr: Add tests for 'formdata' event (#14637)

Specification PR: whatwg/html#4239

--

wpt-commits: c547389199647f1736be244a7ca5a874da692430
wpt-pr: 14637

UltraBlame original commit: c0fe813241a5041aec5fd25054a003016720745c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…t, a=testonly

Automatic update from web-platform-tests
html, xhr: Add tests for 'formdata' event (#14637)

Specification PR: whatwg/html#4239

--

wpt-commits: c547389199647f1736be244a7ca5a874da692430
wpt-pr: 14637

UltraBlame original commit: c71f7d3fa10b69185c90a1537bb49989a0fd4604
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…t, a=testonly

Automatic update from web-platform-tests
html, xhr: Add tests for 'formdata' event (#14637)

Specification PR: whatwg/html#4239

--

wpt-commits: c547389199647f1736be244a7ca5a874da692430
wpt-pr: 14637

UltraBlame original commit: c0fe813241a5041aec5fd25054a003016720745c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

UltraBlame original commit: c8fbe42eba386afe9d98da72ebfbcb15b0995ed1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

UltraBlame original commit: 1ac7b20bb1d8c5528211fdba0246f7659bff3a7c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

UltraBlame original commit: 220138300dd887fb4d05e55a45b9bf9ac78e3584
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

UltraBlame original commit: c8fbe42eba386afe9d98da72ebfbcb15b0995ed1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

UltraBlame original commit: 1ac7b20bb1d8c5528211fdba0246f7659bff3a7c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

UltraBlame original commit: 220138300dd887fb4d05e55a45b9bf9ac78e3584
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

UltraBlame original commit: c8fbe42eba386afe9d98da72ebfbcb15b0995ed1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

UltraBlame original commit: 1ac7b20bb1d8c5528211fdba0246f7659bff3a7c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…ug,edgar

For Event-based form participation specification PR:
whatwg/html#4239

Differential Revision: https://phabricator.services.mozilla.com/D43986

UltraBlame original commit: 220138300dd887fb4d05e55a45b9bf9ac78e3584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.