Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendering: Update the conditions where an image creates a replaced box. #4406

Merged
merged 2 commits into from Mar 4, 2019

Conversation

@emilio
Copy link
Contributor

commented Mar 2, 2019

This updates the spec for two changes I've done / doing to Firefox, which also
match WebKit and Blink:

In particular, the two cases that need to work are:

  • <img> (without alt text) creates a replaced box, regardless of specified
    dimensions or what not.

  • <img src="foo" alt="bar"> creates a replaced box while the image is
    loading, rather than an inline.

I added tests for the first in https://phabricator.services.mozilla.com/D11194,
since it matches all implementations.

I don't know how to add a test for the second that isn't racy.


/rendering.html ( diff )

This updates the spec for two changes I've done / doing to Firefox, which also
match WebKit and Blink:

 * https://bugzilla.mozilla.org/show_bug.cgi?id=1196668
 * https://bugzilla.mozilla.org/show_bug.cgi?id=1472637

In particular, the two cases that need to work are:

 * `<img>` (without `alt` text) creates a replaced box, regardless of specified
   dimensions or what not.

 * `<img src="foo" alt="bar">` creates a replaced box while the image is
   loading, rather than an inline.

I added tests for the first in https://phabricator.services.mozilla.com/D11194,
since it matches all implementations.

I don't know how to add a test for the second that isn't racy.
@emilio

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

r? @annevk

@annevk

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

So this addresses all of #3614 (comment), right? This looks okay, modulo a nit I'll push a commit for.

nit
@annevk

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

For the second case, you can make the server delay sending a response for 5-10s or so, but I'm not sure if you can force a reftest to happen before somehow. If you can test it via script that'd be sufficient though.

@annevk

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

I also see you are currently signed up as an individual whereas you work for Mozilla, we'll need to fix that. I invited you to an organization you'll need to be a public member of.

@annevk
annevk approved these changes Mar 4, 2019
@annevk annevk merged commit f9e4c66 into whatwg:master Mar 4, 2019
2 checks passed
2 checks passed
Participation emilio participates on behalf of Mozilla Corporation
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.