Change pseudo-classes selector <dfn> to noexport #449

Closed
wants to merge 2 commits into
from

Conversation

2 participants
@Ritsyy
Collaborator

Ritsyy commented Dec 24, 2015

Fixes #284

source
<dd>
<p>The <code data-x="selector-active">:active</code> pseudo-class is defined to match an element
<q cite="https://drafts.csswg.org/selectors3/#the-user-action-pseudo-classes-hover-act">while an
- element is <dfn><i data-x="concept-selector-active">being activated</i></dfn> by the user</q>.</p>
+ element is <dfn data-noexport=""><i data-x="concept-selector-active">being activated</i></dfn> by the user</q>.</p>

This comment has been minimized.

@domenic

domenic Dec 24, 2015

Member

I think this one should stay exported; it is not defined in https://drafts.csswg.org/selectors3/ from what I can tell.

@domenic

domenic Dec 24, 2015

Member

I think this one should stay exported; it is not defined in https://drafts.csswg.org/selectors3/ from what I can tell.

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Dec 24, 2015

Member

Almost good. Can you remove the one I commented on, and amend the commit message to spell pseudo correctly?

Member

domenic commented Dec 24, 2015

Almost good. Can you remove the one I commented on, and amend the commit message to spell pseudo correctly?

@Ritsyy

This comment has been minimized.

Show comment
Hide comment
@Ritsyy

Ritsyy Dec 24, 2015

Collaborator

ah, spelling mistake. Yeah sure will do. Saw https://drafts.csswg.org/selectors3/ , you are right changing this to export.

Collaborator

Ritsyy commented Dec 24, 2015

ah, spelling mistake. Yeah sure will do. Saw https://drafts.csswg.org/selectors3/ , you are right changing this to export.

@Ritsyy Ritsyy changed the title from Change pseduo-classes selector <dfn> to noexport to Change pseudo-classes selector <dfn> to noexport Dec 24, 2015

domenic added a commit that referenced this pull request Dec 28, 2015

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Dec 28, 2015

Member

Thank you! Merged as 0408f76

Member

domenic commented Dec 28, 2015

Thank you! Merged as 0408f76

@domenic domenic closed this Dec 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment