Change document's fully active conditon #462

Closed
wants to merge 1 commit into
from

Conversation

2 participants
@Ritsyy
Collaborator

Ritsyy commented Jan 4, 2016

Fix #388
A document without a browsing context shouldn't be fully active. See #1218456 for context.

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Jan 5, 2016

Member

Content-wise LGTM.

The wrapping looks weird. Each line should be indented the same and collapse spaces into one.

Can you squash into one commit? Also change the commit message per https://github.com/erlang/otp/wiki/Writing-good-commit-messages#do -- e.g.

Fix #388: Change document's fully active condition

A document without a browsing context shouldn't be fully active.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1218456 for context.
Member

zcorpan commented Jan 5, 2016

Content-wise LGTM.

The wrapping looks weird. Each line should be indented the same and collapse spaces into one.

Can you squash into one commit? Also change the commit message per https://github.com/erlang/otp/wiki/Writing-good-commit-messages#do -- e.g.

Fix #388: Change document's fully active condition

A document without a browsing context shouldn't be fully active.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1218456 for context.
@Ritsyy

This comment has been minimized.

Show comment
Hide comment
@Ritsyy

Ritsyy Jan 5, 2016

Collaborator

yes the 2nd commit i did was for wrapping the content, i'll squash into one and make the content look right. and will change the commit message, thanks

Collaborator

Ritsyy commented Jan 5, 2016

yes the 2nd commit i did was for wrapping the content, i'll squash into one and make the content look right. and will change the commit message, thanks

@Ritsyy Ritsyy changed the title from changes a document's fully active conditon to Change document's fully active conditon Jan 6, 2016

zcorpan added a commit that referenced this pull request Jan 11, 2016

Change document's fully active condition
A document without a browsing context shouldn't be fully active.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1218456 for context.

PR: #462
@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Jan 11, 2016

Member

Merged as 8700e2c thanks!

Member

zcorpan commented Jan 11, 2016

Merged as 8700e2c thanks!

@zcorpan zcorpan closed this Jan 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment