From edd3dc0cb2ccad899920112fa3d67057789ec66a Mon Sep 17 00:00:00 2001 From: ritsyy Date: Thu, 11 Feb 2016 16:39:44 +0530 Subject: [PATCH] Use enum for lineCap/lineJoin/textAlign/textBaseline/direction Fix https://www.w3.org/Bugs/Public/show_bug.cgi?id=27315. --- source | 70 ++++++++++++++++++++++------------------------------------ 1 file changed, 27 insertions(+), 43 deletions(-) diff --git a/source b/source index 7e707d4afb0..b2fabab0e1c 100644 --- a/source +++ b/source @@ -60026,12 +60026,18 @@ interface CanvasImageData { void putImageData(ImageData imagedata, double dx, double dy, double dirtyX, double dirtyY, double dirtyWidth, double dirtyHeight); }; +enum CanvasLineCap { "butt", "round", "square" }; +enum CanvasLineJoin { "round", "bevel", "miter"}; +enum CanvasTextAlign { "start", "end", "left", "right", "center" }; +enum CanvasTextBaseline { "top", "hanging", "middle", "alphabetic", "ideographic", "bottom" }; +enum CanvasDirection { "ltr", "rtl", "inherit" }; + [NoInterfaceObject, Exposed=(Window,Worker)] interface CanvasPathDrawingStyles { // line caps/joins attribute unrestricted double lineWidth; // (default 1) - attribute DOMString lineCap; // "butt", "round", "square" (default "butt") - attribute DOMString lineJoin; // "round", "bevel", "miter" (default "miter") + attribute CanvasLineCap lineCap; // (default "butt") + attribute CanvasLineJoin lineJoin; // (default "miter") attribute unrestricted double miterLimit; // (default 10) // dashed lines @@ -60044,9 +60050,9 @@ interface CanvasPathDrawingStyles { interface CanvasTextDrawingStyles { // text attribute DOMString font; // (default 10px sans-serif) - attribute DOMString textAlign; // "start", "end", "left", "right", "center" (default: "start") - attribute DOMString textBaseline; // "top", "hanging", "middle", "alphabetic", "ideographic", "bottom" (default: "alphabetic") - attribute DOMString direction; // "ltr", "rtl", "inherit" (default: "inherit") + attribute CanvasTextAlign textAlign; // (default: "start") + attribute CanvasTextBaseline textBaseline; // (default: "alphabetic") + attribute CanvasDirection direction; // (default: "inherit") }; [NoInterfaceObject, Exposed=(Window,Worker)] @@ -60923,10 +60929,8 @@ idea from Mihai: data-x="">butt", "round", and "square".

-

On getting, it must return the current value. On setting, if the new value is one of the - literal strings "butt", "round", and "square", then the current value must be changed to the new value; other values - must ignored, leaving the value unchanged.

+

On getting, it must return the current value. On setting, the current value must be changed + to the new value.

When the object implementing the CanvasPathDrawingStyles interface is created, the lineCap attribute must initially have the value @@ -60938,10 +60942,8 @@ idea from Mihai: of corners that UAs will place where two lines meet. The three valid values are "bevel", "round", and "miter".

-

On getting, it must return the current value. On setting, if the new value is one of the - literal strings "bevel", "round", and "miter", then the current value must be changed to the new value; other values - must be ignored, leaving the value unchanged.

+

On getting, it must return the current value. On setting, the current value must be changed + to the new value.

When the object implementing the CanvasPathDrawingStyles interface is created, the lineJoin attribute must initially have the value @@ -61384,40 +61386,22 @@ transform. ack Shaun Morris. --> interpreted relative to the normal-weight 10px sans-serif default.

The textAlign IDL attribute, on - getting, must return the current value. On setting, if the value is one of start, end, left, right, or center, then the value must be changed to the new - value. Otherwise, the new value must be ignored. When the object implementing the - CanvasTextDrawingStyles interface is created, the textAlign attribute must initially have the value start.

+ getting, must return the current value. On setting, the current value must be changed to the new + value. When the object implementing the CanvasTextDrawingStyles interface is + created, the textAlign attribute must initially + have the value start.

The textBaseline IDL attribute, on - getting, must return the current value. On setting, if the value is one of top, hanging, middle, alphabetic, ideographic, or bottom, then the value must be changed to the - new value. Otherwise, the new value must be ignored. When the object implementing the - CanvasTextDrawingStyles interface is created, the textBaseline attribute must initially have the value - alphabetic.

+ getting, must return the current value. On setting, the current value must be changed to the new + value. When the object implementing the CanvasTextDrawingStyles interface is + created, the textBaseline attribute must + initially have the value alphabetic.

The direction IDL attribute, on - getting, must return the current value. On setting, if the value is one of "ltr", "rtl", or "inherit", then the value must be changed to the - new value. Otherwise, the new value must be ignored. When the object implementing the - CanvasTextDrawingStyles interface is created, the direction attribute must initially have the value "inherit".

+ getting, must return the current value. On setting, the current value must be changed to the new + value. When the object implementing the CanvasTextDrawingStyles interface is + created, the direction attribute must initially + have the value "inherit".