Adding [SameObject] to DOMTokenLists #700

Closed
wants to merge 1 commit into
from

Conversation

4 participants
@Ritsyy
Collaborator

Ritsyy commented Feb 16, 2016

Fix #580.

source
@@ -8945,7 +8945,7 @@ partial /*sealed*/ interface <dfn>Document</dfn> {
attribute DOMString <span data-x="dom-accessKey">accessKey</span>;
readonly attribute DOMString <span data-x="dom-accessKeyLabel">accessKeyLabel</span>;
attribute boolean <span data-x="dom-draggable">draggable</span>;
- [PutForwards=<span data-x="dom-DOMTokenList-value">value</span>] readonly attribute <span>DOMTokenList</span> <span data-x="dom-dropzone">dropzone</span>;
+ [PutForwards=<span data-x="dom-DOMTokenList-value">value</span>] [SameObject] readonly attribute <span>DOMTokenList</span> <span data-x="dom-dropzone">dropzone</span>;

This comment has been minimized.

@annevk

annevk Feb 16, 2016

Member

I think we want to copy the DOM Standard here and use [SameObject, PutForwards=value].

@annevk

annevk Feb 16, 2016

Member

I think we want to copy the DOM Standard here and use [SameObject, PutForwards=value].

This comment has been minimized.

@Ritsyy

Ritsyy Feb 16, 2016

Collaborator

yes you are right, thanks.

@Ritsyy

Ritsyy Feb 16, 2016

Collaborator

yes you are right, thanks.

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Feb 16, 2016

Member

Remove "The same DOMTokenList object must be returned every time for each attribute." in #reflect

Member

zcorpan commented Feb 16, 2016

Remove "The same DOMTokenList object must be returned every time for each attribute." in #reflect

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Feb 17, 2016

Member

Committed as ec1dc4d. Thank you @Ritsyy!

Member

annevk commented Feb 17, 2016

Committed as ec1dc4d. Thank you @Ritsyy!

@annevk annevk closed this Feb 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment