Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a setTimeout's entry in the map of active timers after it runs #7377

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Remove a setTimeout's entry in the map of active timers after it runs #7377

merged 2 commits into from
Nov 30, 2021

Commits on Nov 29, 2021

  1. Remove a setTimeout's entry in the map of active timers after it runs 

    It used to be unobservable whether a non-repeating timer that had
already run its callback had an entry in the list of active timers or
not, and so those entries were never removed from the list. However,
calculation of the idle deadline, meaning that if a timer expires and is
never cancelled, the deadline will be in the past.

This change avoids this case by removing non-repeating timers from the
map of active timers after their callback runs.

Closes whatwg#7376.
    Andreu Botella committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    e65ee75 View commit details
    Browse the repository at this point in the history

  2. Also remove non-numeric values in "run steps after a timeout"

    Andreu Botella committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    a654458 View commit details
    Browse the repository at this point in the history