Hyperlink Auditing: Add Content-Type 'text/ping' #7481
Conversation
There was a problem hiding this comment.
This looks pretty good to me. Technically to be fully rigorous we'd want to assemble the full header list (including Ping-To / Ping-From) before this line, but the less-precise way in which they're currently specified is a preexisting problem, and I don't think this change makes that issue worse.
I'll merge tomorrow unless anyone else has any comments before then.
|
Minor nits, but shouldn't |
|
@Kaiido again, I'd ask that you leave review to the editors :). We're happy to provide such fixups to first-time contributors ourselves before merging, as was my plan here. |
|
Alright, just didn't want to let this missed and took the "anyone" to mean it was fine, just like in the other PR I took the "cc @ whatwg/canvas" to mean "please help review". |
|
Hmm, I realized that we actually don't have any tests for this in the web platform tests repository. @fowl2, would you be up for writing them? |
domenic
added
needs tests
|
FWIW, I think it was fine that @Kaiido commented here as it wasn't clear the wrapping and backticks were noticed. |
|
I copied the formatting of the content type literal from somewhere else in the document, so if you're fixing it here it might want to be fixed there too :) I've never done a web platform test before but sounds fun, I'll see if I have some time to give it a go on the weekend. |
|
I worked on some tests in web-platform-tests/wpt#32887 which should unblock landing this. |
domenic
removed
the
needs tests
domenic
force-pushed
the
ping-content-type
branch
from
a341792
to
16cc477
Compare
Automatic update from web-platform-tests Test hyperlink auditing headers For whatwg/html#7481. -- wpt-commits: fd7bc357005c4f85fb73872fd841086c98f75cb3 wpt-pr: 32887
Automatic update from web-platform-tests Test hyperlink auditing headers For whatwg/html#7481. -- wpt-commits: fd7bc357005c4f85fb73872fd841086c98f75cb3 wpt-pr: 32887
fixes #7477
/links.html ( diff )