Fix double "update the navigation API" for fragment navs #9990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
force-pushed
the
fix-double-navigation-api-update
branch
from
7bca3cd
to
304b15b
Compare
domfarolino
approved these changes
Dec 31, 2023
mobounya
pushed a commit
to mobounya/ladybird
that referenced
this pull request
Jul 21, 2024
Update 'update_for_history_step_application' to meet some of the specs introduced in whatwg/html#9856 and in whatwg/html#9990
mobounya
pushed a commit
to mobounya/ladybird
that referenced
this pull request
Jul 21, 2024
Update 'update_for_history_step_application' to meet some of the specs introduced in whatwg/html#9856 and in whatwg/html#9990
mobounya
pushed a commit
to mobounya/ladybird
that referenced
this pull request
Jul 21, 2024
Update 'update_for_history_step_application' to meet some of the specs introduced in whatwg/html#9856 and in whatwg/html#9990
mobounya
pushed a commit
to mobounya/ladybird
that referenced
this pull request
Jul 21, 2024
Update 'update_for_history_step_application' to meet some of the specs introduced in whatwg/html#9856 and in whatwg/html#9990
mobounya
pushed a commit
to mobounya/ladybird
that referenced
this pull request
Jul 21, 2024
Update 'update_for_history_step_application' to meet some of the specs introduced in whatwg/html#9856 and in whatwg/html#9990
mobounya
pushed a commit
to mobounya/ladybird
that referenced
this pull request
Jul 22, 2024
Update 'update_for_history_step_application' to meet some of the specs introduced in whatwg/html#9856 and in whatwg/html#9990
kalenikaliaksandr
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Jul 22, 2024
Update 'update_for_history_step_application' to meet some of the specs introduced in whatwg/html#9856 and in whatwg/html#9990
circl-lastname
pushed a commit
to circl-lastname/serenity
that referenced
this pull request
Jul 22, 2024
Update 'update_for_history_step_application' to meet some of the specs introduced in whatwg/html#9856 and in whatwg/html#9990 (cherry picked from commit 2497f43989af3efa695d0d33de59001cb87bacb6)
nico
pushed a commit
to SerenityOS/serenity
that referenced
this pull request
Jul 22, 2024
Update 'update_for_history_step_application' to meet some of the specs introduced in whatwg/html#9856 and in whatwg/html#9990 (cherry picked from commit 2497f43989af3efa695d0d33de59001cb87bacb6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9826. da3a62e made it easy to pass along the correct navigationType, and thus trigger the proper path through "update the navigation API entries for a same-document navigation".
Also fixes a typographical issue from da3a62e.
/cc @ADKaster; if you have time to take a look that would be much appreciated!
/browsing-the-web.html ( diff )