Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate correct unicode #83

Merged
merged 2 commits into from Oct 4, 2018
Merged

Indicate correct unicode #83

merged 2 commits into from Oct 4, 2018

Conversation

@rwlbuis
Copy link
Contributor

@rwlbuis rwlbuis commented Oct 3, 2018

I think this was meant.


Preview | Diff

@domenic domenic requested a review from annevk Oct 3, 2018
@annevk
annevk approved these changes Oct 4, 2018
Copy link
Member

@annevk annevk left a comment

Thanks, do you want to add yourself to the acknowledgments section?

@annevk
Copy link
Member

@annevk annevk commented Oct 4, 2018

@domenic any idea why the IPR bot didn't spot anything here? Igalia signed up so it doesn't matter, but it's still weird.

@rwlbuis
Copy link
Contributor Author

@rwlbuis rwlbuis commented Oct 4, 2018

Hey Anne, thanks I added myself.

@annevk
Copy link
Member

@annevk annevk commented Oct 4, 2018

Thanks! I'll leave this open for a bit in case it can help @domenic debug the IPR bot issue.

@domenic
Copy link
Member

@domenic domenic commented Oct 4, 2018

Ah dang, yeah, please do leave this open for a bit. My guess is that whatwg/participate.whatwg.org@2f0525c somehow broke the bot (maybe only for master -> master PRs?). Sorry about that.

@domenic
Copy link
Member

@domenic domenic commented Oct 4, 2018

Hmm, it may have been as simple as mimesniff being misconfigured (using application/x-www-urlencoded instead of application/json for payloads). Fixing that and re-delivering the payload made it post the status fine. So, let's keep an eye on it...

@rwlbuis, you'll need to become a member of the Igalia GitHub organization, or publicize your membership if you are already. Then you, or one of us, can re-trigger the check from the "Details" link above.

@rwlbuis
Copy link
Contributor Author

@rwlbuis rwlbuis commented Oct 4, 2018

@domenic right I was listed as private for some reason, I changed it too public. Let me know if I need to do more!

@domenic
Copy link
Member

@domenic domenic commented Oct 4, 2018

All good now! Will leave the merging to @annevk.

@annevk annevk merged commit dc35803 into whatwg:master Oct 4, 2018
2 checks passed
2 checks passed
Participation rwlbuis participates on behalf of Igalia, S.L.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@annevk
Copy link
Member

@annevk annevk commented Oct 4, 2018

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.