-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HTTP rather than ASCII whitespace #90
Conversation
(The reason Travis fails is because HTTP whitespace isn't yet defined by Fetch.) |
Hmm, so I guess I should look into contexts where MIME types can have newlines and how those are handled today (or not handled at all). |
Per #42 (comment) Because of that I think we should use HTTP whitespace here and not HTTP tab or space. Implementations that don't share their MIME type parser across the code base could have slightly more restrictive code in contexts where newlines by definitions cannot show up. @MattMenke2 @asankah I take it that's agreeable? (I'll add some tests for the aforementioned contexts as well if they don't have any for newlines.) Note to self: need to add HTTP whitespace (a code point based version) to Fetch. |
Is this just CRs and LFs? If so, I'm fine with that. |
Yes. |
I updated the tests to also test HTTP newlines (as per above) and created whatwg/fetch#828 to define HTTP whitespace in Fetch for this kind of usage (and added a note that hopefully dissuades others from using it unless they have an eerily similar data structure). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once HTTP whitespace is defined
Automatic update from web-platform-testsMIME types: test 0x0B, 0x0C, and newlines For whatwg/mimesniff#90. -- wpt-commits: 6aeb68e38a61c2e332a7592f5cad640cf58b73f2 wpt-pr: 13615
Automatic update from web-platform-testsMIME types: test 0x0B, 0x0C, and newlines For whatwg/mimesniff#90. -- wpt-commits: 6aeb68e38a61c2e332a7592f5cad640cf58b73f2 wpt-pr: 13615
Automatic update from web-platform-testsMIME types: test 0x0B, 0x0C, and newlines For whatwg/mimesniff#90. -- wpt-commits: 6aeb68e38a61c2e332a7592f5cad640cf58b73f2 wpt-pr: 13615 UltraBlame original commit: 726abced3085ed5e9ef5b0df43e9561cac6f590d
Automatic update from web-platform-testsMIME types: test 0x0B, 0x0C, and newlines For whatwg/mimesniff#90. -- wpt-commits: 6aeb68e38a61c2e332a7592f5cad640cf58b73f2 wpt-pr: 13615 UltraBlame original commit: 726abced3085ed5e9ef5b0df43e9561cac6f590d
Automatic update from web-platform-testsMIME types: test 0x0B, 0x0C, and newlines For whatwg/mimesniff#90. -- wpt-commits: 6aeb68e38a61c2e332a7592f5cad640cf58b73f2 wpt-pr: 13615 UltraBlame original commit: 726abced3085ed5e9ef5b0df43e9561cac6f590d
Tests: web-platform-tests/wpt#13615.
Fixes #89.
Preview | Diff