Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notificationclose event #61

Merged
merged 1 commit into from Jan 25, 2016

Conversation

4 participants
@nsatragno
Copy link
Contributor

commented Jan 25, 2016

This PR adds a notificationclose event to the service worker API, fired for persistent notifications closed by the user. This should satisfy #31 and mozilla/wp-web-push#63.

Right now, the action attribute would be set to null. As an alternative, we might want to split the Notification object into two different objects: NotificationClick and NotificationClose.

@annevk

This comment has been minimized.

Copy link
Member

commented Jan 25, 2016

@beverloo care to review? Looks good to me.

@nicolassatragno could you maybe merge your commits and force push?

@annevk

This comment has been minimized.

Copy link
Member

commented Jan 25, 2016

@nicolassatragno also, thank you for doing this! Much appreciated.

@nsatragno nsatragno force-pushed the nsatragno:master branch from 9aeec8d to 2ddf5e0 Jan 25, 2016

@nsatragno

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2016

@annevk squashed both commits and pushed. Thanks for the quick review 😄

@beverloo

This comment has been minimized.

Copy link
Member

commented Jan 25, 2016

This looks good to me as well. Thank you! :)

beverloo added a commit that referenced this pull request Jan 25, 2016

@beverloo beverloo merged commit 302330f into whatwg:master Jan 25, 2016

@marco-c

This comment has been minimized.

Copy link

commented Jan 26, 2016

Unfortunately for mozilla/wp-web-push#63 I'd need an event when a non-persistent notification gets closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.