Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure promise returning methods don't throw #342

Closed
tyoshino opened this issue Apr 22, 2015 · 1 comment
Closed

Make sure promise returning methods don't throw #342

tyoshino opened this issue Apr 22, 2015 · 1 comment
Labels
editorial Changes that do not affect how the standard is understood.

Comments

@tyoshino
Copy link
Member

I see some call-with-rethrows in promise returning methods' algorithm. Check that they're correctly implemented so that we don't throw but return a rejected promise to conform to http://www.w3.org/2001/tag/doc/promises-guide#always-return-promises.
@domenic
Copy link
Member

domenic commented Apr 22, 2015

Yeah I think what I'm really missing here is something like Call-and-assert-doesn't-throw

@domenic domenic added the editorial Changes that do not affect how the standard is understood. label May 3, 2015
domenic added a commit that referenced this issue Jun 18, 2015
@domenic
Use "perform" for abstract ops that cannot throw
96f9320 
Closes #342, by making it clear that the promise-returning methods do not throw since they always call out to "perform"s or similar.

Also found one case of unnecessary exception guarding, and a few unnecessary ReturnIfAbrupts.

Leaves out ReadableByteStream for now, pending #361.
@domenic domenic mentioned this issue Jun 18, 2015
Merged
domenic added a commit that referenced this issue Jun 18, 2015
@domenic
Use "perform" for abstract ops that cannot throw
9573b64 
Closes #342, by making it clear that the promise-returning methods do not throw since they always call out to "perform"s or similar.

Also found a couple cases of unnecessary exception guarding, and a few unnecessary ReturnIfAbrupts.

Leaves out ReadableByteStream for now, pending #361.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial Changes that do not affect how the standard is understood.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @tyoshino