From d08bfe59cdf46a19763515b6b3621f6dc6c08908 Mon Sep 17 00:00:00 2001 From: Adam Rice Date: Fri, 1 Sep 2017 23:08:14 +0900 Subject: [PATCH] Remove TransformStream _transforming member The _transforming member of TransformStream was used to keep track of whether a call to transformer.transform() was currently in progress. The diagnostic value it provided was minimal, and it served no other purpose, so remove it. --- .../lib/transform-stream.js | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/reference-implementation/lib/transform-stream.js b/reference-implementation/lib/transform-stream.js index 88de6ec82..a1d7dfa85 100644 --- a/reference-implementation/lib/transform-stream.js +++ b/reference-implementation/lib/transform-stream.js @@ -13,7 +13,6 @@ class TransformStream { constructor(transformer = {}, writableStrategy = undefined, readableStrategy = undefined) { this._transformer = transformer; - this._transforming = false; this._errored = false; this._storedError = undefined; @@ -222,11 +221,8 @@ function TransformStreamTransform(transformStream, chunk) { // console.log('TransformStreamTransform()'); assert(transformStream._errored === false); - assert(transformStream._transforming === false); assert(transformStream._backpressure === false); - transformStream._transforming = true; - const transformer = transformStream._transformer; const controller = transformStream._transformStreamController; @@ -234,13 +230,11 @@ function TransformStreamTransform(transformStream, chunk) { TransformStreamDefaultTransform, [chunk, controller]); return transformPromise.then( - () => { - transformStream._transforming = false; - }, - e => { - TransformStreamErrorIfNeeded(transformStream, e); - return Promise.reject(e); - }); + undefined, + e => { + TransformStreamErrorIfNeeded(transformStream, e); + return Promise.reject(e); + }); } // Class TransformStreamDefaultController @@ -350,8 +344,6 @@ class TransformStreamDefaultSink { const transformStream = this._transformStream; - assert(transformStream._transforming === false); - transformStream._writableDone = true; const flushPromise = PromiseInvokeOrNoop(transformStream._transformer,