Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that percent-encoding often does not roundtrip #727

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 16, 2022

Also add some <div algorithm> wrappers to this section.

Closes #523.


cc @karwa


Preview | Diff

Also add some <div algorithm> wrappers to this section.

Closes #523.
@annevk annevk requested a review from domenic December 16, 2022 13:12
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the connection to the original issue. (Probably, I don't understand the original issue.)

The implicit statement here seems to be that because of the URL parser using neither percent-encode set, there are strings where the URL serialization of the URL parsing of "x" is not "x". If that's true, adding an example would be great.

But #523 seems to be talking fairly specifically about the username component, or about some sort of component-wise operation. I can't seem to produce any such strings using the live URL viewer and any of the examples therein.

@annevk
Copy link
Member Author

annevk commented Dec 19, 2022

Yeah, the statement was somewhat confusing. It's more that if you want to put data in a URL that has a % in it, you better percent-encode it first.

@annevk annevk merged commit a05ee27 into main Dec 20, 2022
@annevk annevk deleted the annevk/percent-encoding-roundtrip branch December 20, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Percent encoding does not round-trip
2 participants