Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Mode is in Markdown now #240

Merged
merged 1 commit into from Mar 10, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 6, 2019

See whatwg/sg#88. Needs to be merged afterwards. And also requires #295 and rebasing.

@annevk annevk force-pushed the annevk/convert-working-mode-to-markdown branch from 8df8141 to bed8b36 Compare March 6, 2020 14:56
@annevk

This comment has been minimized.

@annevk annevk requested a review from domenic March 6, 2020 14:59
@annevk annevk changed the base branch from master to annevk/commonmark March 7, 2020 12:03
@annevk annevk force-pushed the annevk/convert-working-mode-to-markdown branch from bed8b36 to 45405e6 Compare March 7, 2020 12:06
annevk added a commit to whatwg/sg that referenced this pull request Mar 7, 2020
@annevk annevk changed the base branch from annevk/commonmark to master March 10, 2020 07:16
See whatwg/sg#88. Needs to be merged afterwards.
@annevk annevk force-pushed the annevk/convert-working-mode-to-markdown branch from 439d7e1 to febe471 Compare March 10, 2020 07:23
@foolip
Copy link
Member

foolip commented Mar 10, 2020

I've compared the built output with these changes and it looks like an <hr> is gone from all the converted files. Is that known/intended?

@foolip
Copy link
Member

foolip commented Mar 10, 2020

Yes, that's very much intentional, I see it in the code now :)

@foolip foolip merged commit 106d765 into master Mar 10, 2020
@foolip foolip deleted the annevk/convert-working-mode-to-markdown branch March 10, 2020 09:21
@foolip
Copy link
Member

foolip commented Mar 10, 2020

"Needs to be merged afterwards." left in commit message because I rebased. Oh well.

@annevk
Copy link
Member Author

annevk commented Mar 10, 2020

Thanks @foolip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants