Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: use HTML/XML MIME type terms #171

Merged
merged 1 commit into from Dec 4, 2017

Conversation

2 participants
@annevk
Copy link
Member

commented Dec 4, 2017

Fixes #160.


Preview | Diff

@annevk annevk merged commit daa0bae into master Dec 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@annevk annevk deleted the annevk/xml-mime-type branch Dec 4, 2017

@domenic

This comment has been minimized.

Copy link
Member

commented Dec 4, 2017

This seems like a normative change in that now you're allowing parameters instead of just "text/html" the literal string. Probably it is a change for the better, but I wanted to check that you were aware.

Unless perhaps the parameters were normalized away earlier and I didn't trace back far enough.

@annevk

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2017

Good point, this actually fixed a longstanding bug then. Now I feel bad about merging it early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.