Upgrade to latest Rails/Ruby #4
Conversation
Thanks for the request, Marcel. I'm finishing up some stuff for my day job and then I'll take a look at this on my holiday break. My first child is due any day now so if I don't get to it in the next week or so that's why. On an initial glance I like some of the changes but have a few suggestions:
I haven't had time to keep updating this reference site with more examples of how to use fitgem in a Rails app. Any additional example content would be greatly appreciated! |
Hi, This was my first pull request, ever! I was a bit excited, and I am glad it Congratulations with your first child. My oldest son is already 16, but I If there is a small thing I can ask you: could you have a look at the
Some background: Thanks for your help, I hope I can contibute to your project . Marcel van Pinxteren Op donderdag 20 december 2012 schreef Zachery Moneypenny (
Met vriendelijke groet, Marcel van PinxterenVolg onze bouw op http://nieuwekampen.blogspot.com |
Hi Marcel- I processed your pull request plus a whole bunch of cleanup. I realized that when I switched over to a better model to represent the content (and integrate some backbone.js for the dynamic data) I failed to remove the old content structure and tests. I'm going to continue to look at further cleanup I can do, but for now I've integrated your changes into master branch and added some new cleanup as well. |
I'm a newbie, so bear with me.
I tried to get the more obvious version conflicts out of the way.
There is still a routing issue, which makes some of the tests fail.
I saw you made some preparations for subscriptions. I would very much like to get this working.