Invalid column not throwing exception in select argument #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an exception in case the column specified in the select or group argument passed in the findAll() function does not exist in the database.
Changed the test case as suggested by @chapmandu
Collaborator
|
Closes #591 |
bpamiri
requested changes
Mar 15, 2023
Collaborator
bpamiri
left a comment
bpamiri
left a comment
There was a problem hiding this comment.
@zainforbjs this is breaking on columns added via a class property as in calculated or aliased columns. Do a search for firstID and you'll see it is defined as a property on the Post model but is getting caught by this exception because the column doesn't exist in the DB.
The test cases that were breaking was due to the group by statement that does not add the calculated property if there is an aggregate function in the query to the group by clause. This was breaking the test case so added the condition to only throw error in case of "select". Also added another condition due to the breaking of self join test case. If the table is self joined, the same columns are already in the select clause so the "local.toAppend" does not get the value in case of duplicate columns from the same table. It gets the columns if the dupes are in different tables as they are then aliased with table dot notation.
Contributor
Author
|
@bpamiri Added some conditions to fix the 5 test cases that were failing. Added details in the commit. |
bpamiri
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an exception in case the column specified in the select or group argument passed in the findAll() function does not exist in the database.