Add Adobe 2021 Support to local Docker testing #1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This finally working. Adobe 2021 is tested against MySQL, SQL Server, and PostgreSQL. Both the GitHub actions tests are passing as well as all local Docker based tests. If using the local Docker tests the code is injected into each VM so the VMs will get the live code updates. |
|
Well done! 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complete some work on the rearchitecture of the configuration files used for the individual docker images for local testing.
The test suite now tests
Lucee 5 (MySQL, SQL Server, PostgreSQL, H2)
Lucee 6 (MySQL, SQL Server, PostgreSQL, H2)
Adobe 2016 (MySQL, SQL Server, PostgreSQL)
Adobe 2018 (MySQL, SQL Server, PostgreSQL)
Adobe 2021 (MySQL, SQL Server, PostgreSQL)
Once other major feature that was completed in this PR is that the local web images properly load the files from the host machine which makes it easier to do local development and have changes reflected in the docker images immediately without requiring any commenting and uncommenting lines in the dockerfile or having to rebuild the images between each cycle.