New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught NumberFormatException on "Add Score" dialog's +1/Undo Buttons #8

Closed
wheerdam opened this Issue Dec 9, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@wheerdam
Owner

wheerdam commented Dec 9, 2017

If the user has a score with +1/Undo score type and typed in an invalid number in the "Add Score" dialog, clicking on either the +1 or Undo button will cause an uncaught NumberFormatException:

Exception in thread "AWT-EventQueue-0" java.lang.NumberFormatException: For input string: "2.0z"
	at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2043)
	at sun.misc.FloatingDecimal.parseDouble(FloatingDecimal.java:110)
	at java.lang.Double.parseDouble(Double.java:538)
	at org.osumercury.controlcenter.gui.ControlFrame$ScoringUpUndoActionListener.actionPerformed(ControlFrame.java:1420)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
...

The "Add Score" dialog is the only place where this is possible since the score text field would not be user-editable otherwise.

@wheerdam wheerdam self-assigned this Dec 9, 2017

@wheerdam wheerdam added the bug label Dec 10, 2017

wheerdam added a commit that referenced this issue Sep 19, 2018

@wheerdam

This comment has been minimized.

Owner

wheerdam commented Sep 19, 2018

Fixed in 1.4.1

@wheerdam wheerdam closed this Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment