Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for signal option #328

Closed
wants to merge 1 commit into from

Conversation

@dutradda
Copy link

dutradda commented Jul 10, 2018

Implements the signal checkpoint of the issue #239

@dutradda dutradda changed the title Added support for signal option #239 Added support for signal option Jul 10, 2018
@wheresrhys

This comment has been minimized.

Copy link
Owner

wheresrhys commented Jul 17, 2018

Thanks for implementing this. Wow - cancellable promises landed quickly.

Before merging I'd like to see some tests for how this impacts the flush() and done() methods. Maybe some other aspects of the API too. In particular, because generating a response can kick off a chain of microtasks, whereas fetch will - I assume - only ever create one, I wonder if there's potential to time the sending of the abort signal in such a way that it'd be too late to stop a genuine fetch, but would be able to intercept fetch-mock. A pretty edge case, but worth at least giving some thought to

@wheresrhys

This comment has been minimized.

Copy link
Owner

wheresrhys commented Jul 29, 2018

Hi @dutradda. Did you see my response?

@dutradda

This comment has been minimized.

Copy link
Author

dutradda commented Jul 30, 2018

Hello @wheresrhys ,

thank's for the reply

I will do the tests with flush() and done() calls

@thommyhh

This comment has been minimized.

Copy link

thommyhh commented Aug 18, 2018

@dutradda @wheresrhys What is the status here? I could really use this right now.

@wheresrhys

This comment has been minimized.

Copy link
Owner

wheresrhys commented Aug 30, 2018

@thommyhh I'm rewriting documentation for v7. Unless @dutradda does so first, I plan on completing this PR after that's done and it will be released in v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.