Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove babel-polyfill #444

Closed
wants to merge 1 commit into from

Conversation

@jelaxshan
Copy link

jelaxshan commented Aug 7, 2019

I have removed babel-polyfill in this PR, as it should be the responsibility of the package consumer to include polyfills. This avoids potential conflicts with other polyfills and removing this polyfill should also reduce bundle size. Additionally babel-polyfill is essentially just core-js under the hood, and there is no need to include both in this lib.

Jelaxshan Jehanathan Jelaxshan Jehanathan
@redaxmedia

This comment has been minimized.

Copy link

redaxmedia commented Aug 13, 2019

I think this is a valid point but merging this should result in an major version bump.

@wheresrhys

This comment has been minimized.

Copy link
Owner

wheresrhys commented Sep 29, 2019

I'll be discussing these compatibility problems with my co-maintainer @grug soon and we'll hopefully release a new version which keeps everybody happy.

@wheresrhys

This comment has been minimized.

Copy link
Owner

wheresrhys commented Oct 26, 2019

v8.0.0-alpha.2 attempts to address this issue. Please leave a 👍 on the pull request #457 if your problem is solved, or alternatively leave a comment @redaxmedia @jelaxshan

@wheresrhys wheresrhys closed this Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.