Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abort): throwing DOMEXception when available #485

Merged
merged 1 commit into from Dec 19, 2019

Conversation

@Sayan751
Copy link

Sayan751 commented Dec 17, 2019

As per spec when a fetch is aborted a DOMException is thrown with name 'AbortError'. However, the current implemnetation threw a custom error instance. That should work for node.js due to unavailibility of DOMException. This commit ensures that when DOMException is available it is thrown instead.

Related: #416

As per spec when a fetch is aborted a DOMException is thrown with
name 'AbortError'. However, the current implemnetation threw a custom
error instance.  That should work for node.js due to unavailibility of
DOMException. This commit ensures that when DOMException is available
it is thrown instead.

Related: #416
@wheresrhys

This comment has been minimized.

Copy link
Owner

wheresrhys commented Dec 19, 2019

Looks good - thanks

@wheresrhys wheresrhys merged commit 5c4f18c into wheresrhys:master Dec 19, 2019
1 check passed
1 check passed
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.