OpenGL rendering #250
Merged
OpenGL rendering #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has a few caveats: - still very messy - libRocket doesn't work, so no GUI
Still on the render thread, next commit should move it to game thread at last
+ move font loading accordingly to FARender::Renderer
# Conflicts: # apps/freeablo/engine/enginemain.cpp # apps/freeablo/farender/renderer.cpp # apps/freeablo/farender/renderer.h # components/render/render.h # components/render/sdl2backend.cpp
Corruption would only occur if we attempted to setImmortal() a raw sprite before we had ever rendered it. get() in SpriteManager handles raw sprites with directInsert, but calling setImmortal would skip straight to SpriteCache::setImmortal, which ensures the sprite exists by calling get() and then setting the immortal flag. However, since this was implemented inside SpriteCache, it wasn't handling raw sprites, so it woul give an invalid sprite cache lookup error, and corrupt the mUsedList member. The solution is to call get() in SpriteManager::setImmortal before calling SpriteCache::SetImmortal, to ensure that the raw sprite is created before we go into SpriteCache.
Fuco1
reviewed
Jul 10, 2017
| # Use C++11 | ||
| if (CMAKE_VERSION VERSION_LESS "3.1") | ||
| if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") | ||
| set (CMAKE_CXX_FLAGS "--std=gnu++11 ${CMAKE_CXX_FLAGS}") |
Contributor
There was a problem hiding this comment.
Any reason not to use c++14? I've had it set locally ever since I've started working on this project and everything seems to work just fine.
Owner
Author
There was a problem hiding this comment.
Travis is still using gcc 4.6.3, I'm not sure how much of c++14 is supported in that?
Contributor
There was a problem hiding this comment.
Oh, I see. No big deal I guess, as far as I can tell we're not using any new features. But it's good to preemptively use newer standards if possible.
wheybags
force-pushed
the
opengl
branch
2 times, most recently
from
7a3f64b to
50b1dfd
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-librocket doesn't work, but I want to get rid of it anyway
(probably for myGui + lua)Nuklear! https://github.com/vurtun/nuklear-probably won't be merged until this is done