New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically build Docker images #301

Closed
anarcat opened this Issue Oct 3, 2018 · 13 comments

Comments

Projects
None yet
2 participants
@anarcat
Contributor

anarcat commented Oct 3, 2018

A key thing of Docker is that there is the Docker hub which automatically builds Docker images for you. This allows users to use your software without having to download (or build!) the source.

There are already two "whipper" Docker images when you search on the hub whipper7/test (probably unrelated) and dartagnan/whipper unofficial build. This means that Docker users are likely to use an unofficial (or totally unrelated) image instead of the one you provide here.

Enabling automated builds of your image is fairly simple:

  1. sign in to hub.docker.com (creating a new account first if not already done)
  2. in the top-right menu, click on Create then Create automated build
  3. this will ask you to link your GitHub account if not already done. do so. you can also grant other GitHub members that have access to your repo later as well so others can operate the build
  4. Once the account is linked, you can Create Auto-build Githb there
  5. then you pick this repository in the list
  6. fill in the details as necessary (optional) and click Save

Then the build should be automatically triggered when changes are performed in the GitHub repository.

I can assist with the creation process if you grant me access, but it would of course be better if you would get familiar with it.

I went through the above process and created the anarcat/whipper repository based on my fork, as an example. I will delete it as soon as this issue is completed.

Thank you for your attention and hard work!

@anarcat

This comment has been minimized.

Contributor

anarcat commented Oct 3, 2018

once that is done, the Docker instructions in the README would become:

docker pull JoeLametta/whipper

instead of the docker build command.

@JoeLametta JoeLametta added the idea label Oct 3, 2018

@JoeLametta

This comment has been minimized.

Collaborator

JoeLametta commented Oct 3, 2018

This is an interesting suggestion, thanks!
I don't know: maybe it would be a good idea to create a Docker Hub account just for whipper?

@anarcat

This comment has been minimized.

Contributor

anarcat commented Oct 3, 2018

@JoeLametta

This comment has been minimized.

Collaborator

JoeLametta commented Oct 6, 2018

@anarcat Sorry, I've got no experience with Docker... 🤣
Let me know if I got it right: are you suggesting to move whipper's repository ownership to a GitHub organization, sign up for a personal Docker Hub account then create a Docker Hub organization (for whipper)?

@anarcat

This comment has been minimized.

Contributor

anarcat commented Oct 6, 2018

@JoeLametta

This comment has been minimized.

Collaborator

JoeLametta commented Oct 6, 2018

All right, in case I perform step 1 later on (after having already enabled the automated build for the current repository, step 2 & 3 done), I expect I can simply switch the Docker Hub target to the GitHub org. repo without having to fiddle with the accounts.

@anarcat

This comment has been minimized.

Contributor

anarcat commented Oct 10, 2018

All right, in case I perform step 1 later on (after having already enabled the automated build for the current repository, step 2 & 3 done), I expect I can simply switch the Docker Hub target to the GitHub org. repo without having to fiddle with the accounts.

well, you'd only two step 2: create a personal docker hub account and hook the build there. when you setup a new org on GitHub, you'd just setup a new, matching, org on docker hub as well and ditch the old one.

@JoeLametta

This comment has been minimized.

Collaborator

JoeLametta commented Oct 16, 2018

Fine, so I sign up on Docker Hub for a personal account, then create an organization (using the account just created) and link the whipper's GitHub (org) repo on to it, right? (sorry, I've never used Docker/Docker Hub before)

@anarcat

This comment has been minimized.

Contributor

anarcat commented Oct 16, 2018

@JoeLametta

This comment has been minimized.

Collaborator

JoeLametta commented Oct 27, 2018

@anarcat joelametta/whipper: done?

😉

@anarcat

This comment has been minimized.

Contributor

anarcat commented Oct 27, 2018

that looks awesome! congrats :)

i've deleted my test repo to avoid any further confusion. unfortunately it seems another repo came up since then, but i guess we can overtake it with a right number of pulls (and stars?):

https://hub.docker.com/r/dartagan/whipper/

@anarcat anarcat closed this Oct 27, 2018

JoeLametta added a commit that referenced this issue Oct 27, 2018

Update README's Docker part with Docker Hub info
Now Docker adopters can use whipper trough Docker Hub's automatically built images.
Thanks to user "anarcat" for proposing and thoroughly explaining how to reach this goal.

Closes #301.
@JoeLametta

This comment has been minimized.

Collaborator

JoeLametta commented Oct 27, 2018

that looks awesome! congrats :)

I've just updated the README: special thanks in f9cb126 's description. 🎉

@anarcat

This comment has been minimized.

Contributor

anarcat commented Oct 27, 2018

awesome thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment