Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Prevent a crash if MusicBrainz release date is missing #139
If MusicBrainz returns data for a CD being ripped but no release date is returned (e.g. https://musicbrainz.org/release/340b94f5-139e-4f7b-90dd-82d04a70c57b), we attempt to set the
To resolve the issue, this PR adds a check to see if there is a value for release date before setting it. I've not added a warning message, as this is already output before the crash occurs:
Not sure if this should have a unit test & if so where it should go (don't seem to be any MusicBrainz unit tests for track ripping?), so I've not added one - let me know if I should.
I think that's fine (similar to what I've mentioned here in the bug report).
Thanks for the PR.