New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker invocation #300

merged 4 commits into from Oct 3, 2018


None yet
2 participants

anarcat commented Oct 3, 2018

There is a syntax error in the Dockerfile. Furthermore, some of the
instructions will fail due to permission errors and other

anarcat and others added some commits Oct 3, 2018

fix Docker invocation
It makes no sense to pass the `-t` argument twice and we need to tell
Docker where to find the Dockerfile. Also, it makes sense to write the
config file in a standard location. In my tests, I also had to create
the directory by hand otherwise I got this error:

    cdparanoia can defeat the audio cache on this drive.
    Adding drive cache behaviour to configuration file.
    Traceback (most recent call last):
      File "/usr/local/bin/whipper", line 11, in <module>
        load_entry_point('whipper==0.7.0', 'console_scripts', 'whipper')()
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/command/", line 36, in main
        ret =
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/command/", line 139, in do
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/command/", line 139, in do
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/command/", line 63, in do
        info[0], info[1], info[2], t.defeatsCache)
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/common/", line 115, in setDefeatsCache
        section = self._findOrCreateDriveSection(vendor, model, release)
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/common/", line 164, in _findOrCreateDriveSection
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/common/", line 58, in write
        shutil.move(path, self._path)
      File "/usr/lib/python2.7/", line 316, in move
        copy2(src, real_dst)
      File "/usr/lib/python2.7/", line 144, in copy2
        copyfile(src, dst)
      File "/usr/lib/python2.7/", line 97, in copyfile
        with open(dst, 'wb') as fdst:
    IOError: [Errno 13] Permission denied: u'/home/worker/.config/whipper/whipper.conf'
remove needless tag version
:latest is implicit so it's useless noise as well.

@JoeLametta JoeLametta changed the title from fix Docker invocation to Fix Docker invocation Oct 3, 2018

@JoeLametta JoeLametta merged commit 6d7e54f into whipper-team:master Oct 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.


JoeLametta commented Oct 3, 2018

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment