New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder Dockerfile for performance #305

Merged
merged 1 commit into from Oct 6, 2018

Conversation

Projects
None yet
2 participants
@anarcat
Contributor

anarcat commented Oct 5, 2018

it's better to install/build whipper at the end of the Dockerfile,
because it will allow us to cache costly operations like locale-gen
while rebuilding with new source changes.

reorder Dockerfile for performance
it's better to install/build whipper at the end of the Dockerfile,
because it will allow us to cache costly operations like locale-gen
while rebuilding with new source changes.
@JoeLametta

This comment has been minimized.

Collaborator

JoeLametta commented Oct 6, 2018

Thanks for the pull request!
I'm not a Docker user but I think cURL can be replaced with wget too (the latter is probably leaner on dependencies): does it make sense?

@anarcat

This comment has been minimized.

Contributor

anarcat commented Oct 6, 2018

@JoeLametta JoeLametta changed the title from reorder Dockerfile for performance to Reorder Dockerfile for performance Oct 6, 2018

@JoeLametta JoeLametta merged commit 8b5e8a6 into whipper-team:master Oct 6, 2018

@JoeLametta

This comment has been minimized.

Collaborator

JoeLametta commented Oct 6, 2018

Merged, thanks!

i trust curl more.

Fine, let's leave it as is.

@anarcat anarcat deleted the anarcat:docker-order branch Oct 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment