Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Time Calculation in Cookie Notification #48

Closed
alien-rat opened this issue May 14, 2024 · 1 comment
Closed

Incorrect Time Calculation in Cookie Notification #48

alien-rat opened this issue May 14, 2024 · 1 comment

Comments

@alien-rat
Copy link

I hope this message finds you well. I am writing to report an issue I have encountered with the time calculation in the cookie notification feature.

When setting the time duration using the following code: ->duration(365 * 24 * 60)
the expected result should be exactly 1 year. However, the notification displays the time as "1 year, 1 month, 1 day," which is incorrect.

Expected Result:
The notification should display the time as "1 year."

Actual Result:
The notification displays the time as "1 year, 1 month, 1 day."

This discrepancy may confuse users and affects the accuracy of the information provided.

@toonvandenbos
Copy link
Member

Hi @alien-rat, this is actually an issue with Carbon's intervals. We added a paragraph in our README regarding this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants