Use PropertyPath from new PropertyAccess component #57

Merged
merged 1 commit into from May 13, 2013

Conversation

Projects
None yet
Contributor

LouTerrailloune commented Feb 28, 2013

Remove deprecated calls in symfony 2.2

good pr

Baachi commented Mar 18, 2013

This will increase the requirement to symfony 2.2 and the bundle would be unusable in 2.1.

maybe branch?

2013/3/18 Markus Bachmann notifications@github.com

This will increase the requirement to symfony 2.2 and the bundle would be
unusable in 2.1.


Reply to this email directly or view it on GitHubhttps://github.com/whiteoctober/WhiteOctoberPagerfantaBundle/pull/57#issuecomment-15041842
.

Contributor

LouTerrailloune commented Mar 18, 2013

@Baachi : second line of readme says 'The master branch of this bundle tracks the Symfony2 master branch.' and 2.2 is released.

@vitaliytv : a 2.1 branch is a good idea.

Baachi commented Mar 18, 2013

@LouTerrailloune I know. But this bundle have only a branch for sf2.0. So currently all users have this line in the composer.json "white-october/pagerfanta-bundle": "dev-master@dev". And this PR will break their projects. This should be considered.

A branch for symfony 2.1 would be great 👍

Contributor

LouTerrailloune commented Mar 18, 2013

I agree, a 2.1 whould be great.

gjuric commented Mar 20, 2013

Any news about this, do you need help?

Contributor

LouTerrailloune commented Mar 21, 2013

I think the owner should now create a 2.1 branch (and a tag ?).

Contributor

aerialls commented Mar 27, 2013

+1 The Symfony2.0 is not maintained anymore. It would be great to have a 2.1 branch and to merge this PR into the master branch and to increase the symfony requirement to ~2.2 ;)

and to tag a 1.0 version in both Pagerfanta and PagerfantaBundle please!

Sybio commented Apr 2, 2013

It would be great if @whiteoctober merge this fix ^^

Contributor

pablodip commented Apr 2, 2013

I will soon!

+1 please

Contributor

LouTerrailloune commented Apr 22, 2013

Come on @pablodip , what is preventing you from adding tags ? issues that need to be fixed ? argument against tags ? please tell us because we just don't understand.

Schnaaf commented May 3, 2013

+1 thanks!

shieldo commented May 3, 2013

+1!

Koc commented May 7, 2013

@pablodip Please merge this PR

richsage merged commit 7d93968 into whiteoctober:master May 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment