Skip to content


Subversion checkout URL

You can clone with
Download ZIP


Use PropertyPath from new PropertyAccess component #57

merged 1 commit into from

Remove deprecated calls in symfony 2.2


good pr


This will increase the requirement to symfony 2.2 and the bundle would be unusable in 2.1.


@Baachi : second line of readme says 'The master branch of this bundle tracks the Symfony2 master branch.' and 2.2 is released.

@vitaliytv : a 2.1 branch is a good idea.


@LouTerrailloune I know. But this bundle have only a branch for sf2.0. So currently all users have this line in the composer.json "white-october/pagerfanta-bundle": "dev-master@dev". And this PR will break their projects. This should be considered.

A branch for symfony 2.1 would be great :+1:


I agree, a 2.1 whould be great.


Any news about this, do you need help?


I think the owner should now create a 2.1 branch (and a tag ?).


+1 The Symfony2.0 is not maintained anymore. It would be great to have a 2.1 branch and to merge this PR into the master branch and to increase the symfony requirement to ~2.2 ;)

and to tag a 1.0 version in both Pagerfanta and PagerfantaBundle please!


It would be great if @whiteoctober merge this fix ^^


I will soon!


+1 please


Come on @pablodip , what is preventing you from adding tags ? issues that need to be fixed ? argument against tags ? please tell us because we just don't understand.


+1 thanks!



Koc commented

@pablodip Please merge this PR

@richsage richsage merged commit 7d93968 into whiteoctober:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 28, 2013
  1. @LouTerrailloune

    Use PropertyPath from new PropertyAccess component

    LouTerrailloune authored
    Remove deprecated calls in symfony 2.2
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 2 deletions.
  1. +4 −2 Twig/PagerfantaExtension.php
6 Twig/PagerfantaExtension.php
@@ -12,7 +12,8 @@
namespace WhiteOctober\PagerfantaBundle\Twig;
use Symfony\Component\DependencyInjection\ContainerInterface;
-use Symfony\Component\Form\Util\PropertyPath;
+use Symfony\Component\PropertyAccess\PropertyPath;
+use Symfony\Component\PropertyAccess\PropertyAccess;
use Pagerfanta\PagerfantaInterface;
@@ -82,7 +83,8 @@ public function renderPagerfanta(PagerfantaInterface $pagerfanta, $viewName = nu
$routeParams = $options['routeParams'];
$pagePropertyPath = new PropertyPath($options['pageParameter']);
$routeGenerator = function($page) use($router, $routeName, $routeParams, $pagePropertyPath) {
- $pagePropertyPath->setValue($routeParams, $page);
+ $propertyAccessor = PropertyAccess::getPropertyAccessor();
+ $propertyAccessor->setValue($routeParams, $pagePropertyPath, $page);
return $router->generate($routeName, $routeParams);
Something went wrong with that request. Please try again.