Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add browser platform #84

Merged
merged 2 commits into from Sep 3, 2019
Merged

add browser platform #84

merged 2 commits into from Sep 3, 2019

Conversation

marcel-ernst
Copy link

have fun

@richsage
Copy link
Contributor

richsage commented Nov 2, 2016

@marcel-ernst please back out the CHANGELOG and version bump changes

@marcel-ernst
Copy link
Author

ok, check it now.

@cadesalaberry
Copy link
Contributor

Any progress ?

@biesbjerg
Copy link

Would love to see this merged in as well.

@GonzaloPS
Copy link

Sorry, How can i install this version?

@euleule
Copy link

euleule commented Sep 20, 2017

Can you merge this please? I just spent hours debugging my tests, until I noticed they fail because of this.

@cadesalaberry
Copy link
Contributor

@richsage any plan for a new release with this PR ?

@richsage
Copy link
Contributor

@cadesalaberry afraid I don't work at White October anymore - probably one for @WoJBurgess

@DennisSmolek
Copy link

This looks good to me,

Can anyone who uses a Browser build confirm the core functions work with this PR?
If not I'll try to find time to do a Browser build of our core app to test this...

@marcel-ernst if you have a hosted version anywhere that would be good enough for me..

@ruisilva450
Copy link

Any news on this being merged?

@MattRiddell
Copy link

Yep just added this to my app and it works fine in browser with this patch

@sampart sampart merged commit a5ae663 into sampart:master Sep 3, 2019
@sampart
Copy link
Owner

sampart commented Sep 3, 2019

Thanks for this, @marcel-ernst, and to everyone who tested.

I've merged this now as you'll see, and have created a release to include it: https://github.com/whiteoctober/cordova-plugin-app-version/releases/tag/0.1.10

Note that, although I've got write permissions on this repository, I'm not a maintainer for this project - #100 still applies - I just merged this as it seemed simple, in-demand and well-tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants