-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boneless Manual Improvements #5
Conversation
Looks good so far! |
Some ideas for renaming the jump instructions. 1: rename 2: The various unconditional instructions will not be changed in this proposal. These instructions are 3: Prefix all the conditional jumps with <opinions based on my personal experience start here, I welcome additional perspectives!> 4: Rename the 5: Rename flags-based jumps to
6: Consider renaming signed and unsigned comparisons. I don't really love any of them, but presented below are some different styles for discussion. I might also like having signed vs. unsigned on the end instead of in the middle, in the vein of MIPS. [table below is good] Note that the entries are signed/unsigned.
|
All looks good to me! |
That should be the branch instructions updated. I want to add a quick reference chapter and then we should merge this. |
Alright, that's all I wanted to do. Should be ready for merging. |
Can you update the spreadsheet too? Also, I think I'll squash the commits, so if you can write a concise summary I can put there that'd be great. |
…making the sections follow it
* improve ALU flag descriptions and related mnemonics (B -> C, O -> V) * improve branch mnemonics (Jcc -> Bcc, new Bf0/Bf1 form, JN -> NOP) * update manual and design spreadsheet with new mnemonics * add Guide to Instruction Set section to manual, which lays out documentation conventions and summarizes the architecture and general behavior * add Quick Reference section to manual, which lists and summarizes all of the instructions * clarify instruction details in manual and correct various errors
Thanks for the PR, and sorry it's taken so long! I've added you to repository collaborators. Anything we have consensus on, feel free to just commit to master. |
This pull request is designed to improve and fix the manual for the Boneless architecture by clarifying and improving the Operation sections, adding material other than the instruction definitions, and ensuring that the manual documents Boneless's behavior as much as possible.
Tasks: