Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added support for legacy DoABC tag. #5

Merged
merged 2 commits into from Jul 8, 2012

Conversation

Projects
None yet
2 participants
Contributor

grindars commented Jul 8, 2012

No description provided.

@whitequark whitequark commented on an outdated diff Jul 8, 2012

lib/furnace-swf/swf/tags/do_abc_tag.rb
- uint32 :flags
- stringz :name
- string :bytecode, :read_length => lambda { parent.real_length - 4 - name.length - 1 }
+ string :bytecode, :read_length => lambda { parent.real_length }
+
+ def name
+ "<DoABCTag>"
@whitequark

whitequark Jul 8, 2012

Owner

You've got indentation wrong here.

@whitequark whitequark commented on an outdated diff Jul 8, 2012

lib/furnace-swf/swf/tags/do_abc_tag.rb
- uint32 :flags
- stringz :name
- string :bytecode, :read_length => lambda { parent.real_length - 4 - name.length - 1 }
+ string :bytecode, :read_length => lambda { parent.real_length }
+
+ def name
+ "<DoABCTag>"
+ end
+
+ def flags
+ 0
@whitequark

whitequark Jul 8, 2012

Owner

Here too.

whitequark added a commit that referenced this pull request Jul 8, 2012

Merge pull request #5 from grindars/master
Added support for legacy DoABC tag.

@whitequark whitequark merged commit 8bf83fb into whitequark:master Jul 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment