Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updated the gemspec using latest Bundler #6

Merged
merged 2 commits into from Jul 9, 2012

Conversation

Projects
None yet
2 participants
Contributor

postmodern commented Jul 9, 2012

  • Split git ls-files using $/ for Windows.
  • Only call git ls-files once.
  • Require Ruby >= 1.9.1, since we're using require_relative.

@whitequark whitequark commented on the diff Jul 9, 2012

furnace-swf.gemspec
@@ -13,11 +13,13 @@ Gem::Specification.new do |s|
%q{Flash SWF files. It can be used with furnace-avm2 in } <<
%q{order to achieve impressive results.}
- s.files = `git ls-files`.split("\n")
- s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
- s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+ s.files = `git ls-files`.split($/)
+ s.executables = s.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
@whitequark

whitequark Jul 9, 2012

Owner

That's the default output of bundler gem. Is it wrong, then? Should this be fixed upstream?

@whitequark

whitequark Jul 9, 2012

Owner

Oops, the title somehow slipped my attention. I see now.

@whitequark whitequark commented on the diff Jul 9, 2012

furnace-swf.gemspec
s.require_paths = ["lib"]
+ s.required_ruby_version = '>= 1.9.1'
@whitequark

whitequark Jul 9, 2012

Owner

Aha, thanks, I did not know about this feature. Is it possible to specify minimal patchlevels for rubies? E.g. furnace-avm2 is known to crash 1.9.2-p0 and IIRC p180.

@postmodern

postmodern Jul 10, 2012

Contributor

Double checked, and apparently you can specify the patch-level.

">= 1.9.2.180"
@whitequark

whitequark Jul 10, 2012

Owner

Yeah, thanks. As I've just got a nonreproducible crash on 1.9.3-p320, I'll leave it as it is.

@whitequark whitequark added a commit that referenced this pull request Jul 9, 2012

@whitequark whitequark Merge pull request #6 from postmodern/master
Updated the gemspec using latest Bundler
c394f6b

@whitequark whitequark merged commit c394f6b into whitequark:master Jul 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment