Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rubysl to Gemfile for Travic CI. #118

Merged
merged 2 commits into from Dec 9, 2013
Merged

Conversation

brixen
Copy link
Contributor

@brixen brixen commented Dec 9, 2013

I'm submitting a patch to Bundler after discussing with Andre that will
enable Rubinius to designate rubysl as gems that are bundled with the
distribution and Bundler will use that information while resolving.

This patch is a stop-gap measure and I can submit another PR to remove
this once Bundler with that patch is released.

I'm submitting a patch to Bundler after discussing with Andre that will
enable Rubinius to designate rubysl as gems that are bundled with the
distribution and Bundler will use that information while resolving.

This patch is a stop-gap measure and I can submit another PR to remove
this once Bundler with that patch is released.

platforms :rbx do
gem 'rubysl', '~> 2.0'
gem 'rubinius', '~> 2.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rubinius gem includes the rubinius-developer_tools and rubinius-build_tools gems, but not rubysl? But the rubinius repo Gemfile doesn't require all of rubysl? https://github.com/rubinius/rubinius/blob/0a59255/Gemfile#L7

@yorickpeterse
Copy link
Contributor

Personally don't have anything against this patch, @whitequark what do you think?

@bf4
Copy link
Collaborator

bf4 commented Dec 9, 2013

@yorickpeterse @whitequark You'll probably want to add cache: bundler to your travis.yml to minimize all the http requests to download all the gems. I'm happy to make that commit (or PR if you want). see bf4/bf4.github.com@b911d7c

@yorickpeterse
Copy link
Contributor

Hm, that feature is actually neat. I'll have to look into that myself as well.

@bf4
Copy link
Collaborator

bf4 commented Dec 9, 2013

@yorickpeterse Yeah, pretty new.

whitequark added a commit that referenced this pull request Dec 9, 2013
Added rubysl to Gemfile for Travic CI.
@whitequark whitequark merged commit 73f8657 into whitequark:master Dec 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants