Added rubysl to Gemfile for Travic CI. #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm submitting a patch to Bundler after discussing with Andre that will enable Rubinius to designate rubysl as gems that are bundled with the distribution and Bundler will use that information while resolving. This patch is a stop-gap measure and I can submit another PR to remove this once Bundler with that patch is released.
Collaborator
There was a problem hiding this comment.
The rubinius gem includes the rubinius-developer_tools and rubinius-build_tools gems, but not rubysl? But the rubinius repo Gemfile doesn't require all of rubysl? https://github.com/rubinius/rubinius/blob/0a59255/Gemfile#L7
Contributor
|
Personally don't have anything against this patch, @whitequark what do you think? |
Collaborator
|
@yorickpeterse @whitequark You'll probably want to add |
Contributor
|
Hm, that feature is actually neat. I'll have to look into that myself as well. |
Collaborator
|
@yorickpeterse Yeah, pretty new. |
whitequark
added a commit
that referenced
this pull request
Dec 9, 2013
Added rubysl to Gemfile for Travic CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a patch to Bundler after discussing with Andre that will
enable Rubinius to designate rubysl as gems that are bundled with the
distribution and Bundler will use that information while resolving.
This patch is a stop-gap measure and I can submit another PR to remove
this once Bundler with that patch is released.