Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ ruby27.y: Allow trailing comma in hash pattern #661

Merged

Conversation

@koic
Copy link
Collaborator

koic commented Apr 1, 2020

This commit tracks upstream commit ruby/ruby@93aaa0b.

This is the following commit cherry picked from 2.8.0-dev to 2.7.1.
ruby/ruby@d25a4f4

Closes #655.

This commit tracks upstream commit ruby/ruby@93aaa0b.

This is the following commit cherry picked from 2.8.0-dev to 2.7.1.
ruby/ruby@d25a4f4

Closes #655.
Copy link
Collaborator

iliabylich left a comment

👍 I'm actually confused that trailing comma in array pattern changes semantics, but for hash pattern it doesn't change anything

@iliabylich iliabylich merged commit 900a652 into whitequark:master Apr 1, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@koic koic deleted the koic:allow_trailing_comma_in_hash_pattern branch Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.