Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating of Buffer with source #693

Merged
merged 1 commit into from May 18, 2020
Merged

Conversation

@marcandre
Copy link
Contributor

marcandre commented May 18, 2020

I find it inconvenient that a Source::Buffer can not be created in one go. I feel that creation of mostly immutable objects should be, if possible, atomic.

Could we add a source: named parameter to the constructor of Buffer?

@marcandre marcandre force-pushed the marcandre:buffer_new branch from fdd09c5 to 828507a May 18, 2020
Copy link
Collaborator

iliabylich left a comment

Thanks! LGTM

@iliabylich iliabylich merged commit 2b60937 into whitequark:master May 18, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.