Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ emit "endless method def" as `:def` node. #716

Merged

Conversation

@iliabylich
Copy link
Collaborator

@iliabylich iliabylich commented Jun 27, 2020

(according to #676 (comment))

2.8.0-dev is not released, so I think we are free to change it.

@iliabylich
Copy link
Collaborator Author

@iliabylich iliabylich commented Jun 27, 2020

@marcandre PTAL, for some reason GH doesn't allow me to request a review from you

Copy link
Contributor

@marcandre marcandre left a comment

LGTM

@iliabylich iliabylich merged commit fc32051 into whitequark:master Jul 1, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@iliabylich iliabylich deleted the iliabylich:emit-endless-method-def-as-def-node branch Jul 1, 2020
@palkan
Copy link
Contributor

@palkan palkan commented Jul 2, 2020

@iliabylich I tried to migrate to this version and found that it doesn't work in a way we it was discussed: node.loc.end.nil? couldn't be used, since Map::EndlessDefinition has no #end method. Not sure what is a proper way to fix this: drop EndlessDefinition and add assignment to Definition or inherit EndlessDefinition from Definition or simply duplicate attr_accessor :end. @marcandre Thoughts?

@marcandre
Copy link
Contributor

@marcandre marcandre commented Jul 2, 2020

marcandre added a commit to marcandre/parser that referenced this pull request Jul 4, 2020
@marcandre
Copy link
Contributor

@marcandre marcandre commented Jul 4, 2020

@iliabylich I tried to migrate to this version and found that it doesn't work in a way we it was discussed: node.loc.end.nil? couldn't be used, since Map::EndlessDefinition has no #end method. Not sure what is a proper way to fix this: drop EndlessDefinition and add assignment to Definition or inherit EndlessDefinition from Definition or simply duplicate attr_accessor :end. @marcandre Thoughts?

#718 should be a good solution

marcandre added a commit to marcandre/parser that referenced this pull request Jul 6, 2020
iliabylich pushed a commit that referenced this pull request Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.